From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Jian Yang" <jian.yang@mediatek.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Jianjun Wang" <jianjun.wang@mediatek.com>,
"Rob Herring" <robh@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Chuanjia.Liu@mediatek.com, Jieyy.Yang@mediatek.com,
Qizhong.Cheng@mediatek.com
Subject: Re: [PATCH v3 1/2] dt-bindings: PCI: mediatek-gen3: Add support for controlling power and reset
Date: Tue, 10 Oct 2023 11:45:55 +0200 [thread overview]
Message-ID: <50bb99ee-8ef3-343e-7359-526662f511cb@collabora.com> (raw)
In-Reply-To: <20231009084957.18536-2-jian.yang@mediatek.com>
Il 09/10/23 10:49, Jian Yang ha scritto:
> From: "jian.yang" <jian.yang@mediatek.com>
>
> Add new properties to support control power supplies and reset pin of
> a downstream component.
>
> Signed-off-by: jian.yang <jian.yang@mediatek.com>
> ---
> .../bindings/pci/mediatek-pcie-gen3.yaml | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> index 7e8c7a2a5f9b..eb4ad98549d1 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -84,6 +84,26 @@ properties:
> items:
> enum: [ phy, mac ]
>
> + pcie1v8-supply:
There are another two controllers having such regulators and they all have the
same name for those supplies; Can you please change the names to be consistent
with the other controllers?
vpcie1v8
vpcie3v3
vpcie12v
Regards,
Angelo
next prev parent reply other threads:[~2023-10-10 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 8:49 [PATCH v3 0/2] PCI: mediatek-gen3: Support controlling power supplies Jian Yang
2023-10-09 8:49 ` [PATCH v3 1/2] dt-bindings: PCI: mediatek-gen3: Add support for controlling power and reset Jian Yang
2023-10-10 9:45 ` AngeloGioacchino Del Regno [this message]
2023-10-13 9:25 ` Jian Yang (杨戬)
2023-10-09 8:49 ` [PATCH v3 2/2] PCI: mediatek-gen3: Add power and reset control feature for downstream component Jian Yang
2023-10-10 9:51 ` AngeloGioacchino Del Regno
2023-10-13 9:43 ` Jian Yang (杨戬)
-- strict thread matches above, loose matches on Subject: below --
2023-09-28 10:58 [PATCH v3 0/2] PCI: mediatek-gen3: Support controlling power supplies Jian Yang
2023-09-28 10:58 ` [PATCH v3 1/2] dt-bindings: PCI: mediatek-gen3: Add support for controlling power and reset Jian Yang
2023-09-28 14:47 ` Rob Herring
2023-09-28 15:12 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50bb99ee-8ef3-343e-7359-526662f511cb@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Chuanjia.Liu@mediatek.com \
--cc=Jieyy.Yang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Qizhong.Cheng@mediatek.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=jian.yang@mediatek.com \
--cc=jianjun.wang@mediatek.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).