From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH v2] mtd: nand: mtk: use nand_reset() to reset NAND devices in resume function Date: Thu, 2 Nov 2017 12:41:41 +0100 Message-ID: <5191916b-3b80-7694-74a3-abdf7b18b0d8@gmail.com> References: <1509588307-38511-1-git-send-email-xiaolei.li@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1509588307-38511-1-git-send-email-xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, bayi.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, rogercc.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org List-Id: linux-mediatek@lists.infradead.org On 11/02/2017 03:05 AM, xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote: > From: Xiaolei Li > > Previously, we only select chips and then send reset command to a NAND > device during resuming nand driver. There is a lack of deselecting chips. > It is advised to reset and initialize a NAND device using nand_reset(). > > Signed-off-by: Xiaolei Li > --- Reviewed-by: Matthias Brugger > drivers/mtd/nand/mtk_nand.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/mtd/nand/mtk_nand.c b/drivers/mtd/nand/mtk_nand.c > index d86a7d1..6d0101e 100644 > --- a/drivers/mtd/nand/mtk_nand.c > +++ b/drivers/mtd/nand/mtk_nand.c > @@ -1540,7 +1540,6 @@ static int mtk_nfc_resume(struct device *dev) > struct mtk_nfc *nfc = dev_get_drvdata(dev); > struct mtk_nfc_nand_chip *chip; > struct nand_chip *nand; > - struct mtd_info *mtd; > int ret; > u32 i; > > @@ -1553,11 +1552,8 @@ static int mtk_nfc_resume(struct device *dev) > /* reset NAND chip if VCC was powered off */ > list_for_each_entry(chip, &nfc->chips, node) { > nand = &chip->nand; > - mtd = nand_to_mtd(nand); > - for (i = 0; i < chip->nsels; i++) { > - nand->select_chip(mtd, i); > - nand->cmdfunc(mtd, NAND_CMD_RESET, -1, -1); > - } > + for (i = 0; i < chip->nsels; i++) > + nand_reset(nand, i); > } > > return 0; >