From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C5B7CA0ED3 for ; Mon, 11 Aug 2025 18:44:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TvyCEuzC+XGQIfI6+Ojs1caIw/9527DVynHbE5eSZOc=; b=mmx93iz0qA1RP4fa980gixkz8+ eEg30fckVltwgIZ9scHNUkIlgklgudMDqQOxyLS/lgH4yuv/gt8FgcaU02Kskxg1FK4vP5U9tC5X9 76qY79+saiEytkHdkOYmWz6rbLEWERLMhrO8g44p/gItJo4DO2+bJvRBrUNqk3BpUqhbRThGDFD2s fWM6aljXHA2tTY5+0WHgaTgmVbAEzD6ZH54EsdFs0gUUt6mBsp0sVNPiwdGrugs3Co5y65n5K4AiP 5vW1cqNCX6D1EfohlZUl4nzMB/5BF/PnQogjEDOnThlHLnbgdzC4gOQlSkkUDPMyt90dW6hb9DwFn cnH9WPkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulXVf-00000008p3a-1ml1; Mon, 11 Aug 2025 18:44:39 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulUvo-00000008J8A-0JDM; Mon, 11 Aug 2025 15:59:29 +0000 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-6153a19dddfso6865463a12.1; Mon, 11 Aug 2025 08:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754927966; x=1755532766; darn=lists.infradead.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=TvyCEuzC+XGQIfI6+Ojs1caIw/9527DVynHbE5eSZOc=; b=DXV1zuG8RJsLqBp5Sz45GynrLXRqZxrltJUWqlDgqjMr3NstNQ2y7cbYR+BI6eaYUw /KKlCqdUGR4gf5q319I+5ah9nqZulu+UtRdu7D1LjveBaK8b58tDtRGohzMs4G3ZkBLz M5naIjIR+IKRN612+quxBZsIO7+qv4BXrkMCQehMYHAVRxdMxhJdEplTKT13pZXq5Ws2 XsR4BttP3Dl1IRjTtR7nbh1juiS3uIJech2Cn0GLgNhqbfmZ6Woo+o3e63uOz7Ngo7MW 66uFRDBiLwpjQZbbL0TxCZWKVa4cS3T/MgMT8lKYKam8FmILikt8KhPgkt8mwRpXytxX 4C6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754927966; x=1755532766; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TvyCEuzC+XGQIfI6+Ojs1caIw/9527DVynHbE5eSZOc=; b=H6be7eGDSacN+GuzG+ZcZAuULh6oDB2XPGpGf1rlVLqdgIz0Z4P9dUUQZqnht0icbV ISc4FY4gBKJ7TJa5jaWSaIMX51AUCxPiwwEH4PAYXU7xeEKleux7JtSO3KwH5Uyzsz3g spzHud5oUJRcw2BYPBjxVS4/MuvmNHr7ZFK4r+g3iGKJpZEORjRcHWlNIo2xSuvQ9ApP zO0r/29/tWTAzW0EpT4RRzhmjPmsUmMGNTh7ZuvXOZuPG600mOSPDvDWC/G2IHMM4ygj xRfZkIqIFtpd09/7a6vw74zAKejqrXmoUWguf/02AnkIo+Vq+QQNXBfgKCC7MmFWgCVe 0Yzw== X-Forwarded-Encrypted: i=1; AJvYcCUzFMbXt5I9ewGD3RYJYresxp66IOPIq+f/je0udGe0qJ/FeDgoolioh9xx5eNdB9sEC1uCFMgP+1QVzItz@lists.infradead.org, AJvYcCVMYaKode4OXiEyXp1Vqp5aw/hocnsGe5BwMaw+4qve4LdNBm+ABaLi3g9N/YUnI4SgpBrXDEf9XODQ84hmfWQ=@lists.infradead.org, AJvYcCVQ6m1QNuVZTjNCM6n7M2FFvtYTvOP4cvjI782J7+ZotfMQ9CKqtV5ju8sF+w+kTaHZsl9PpzCMJNGeHU0=@lists.infradead.org, AJvYcCXhoRc2d7CHynRSXEncgrDu44eB0c5KGGT4nCOJ8ypJ1p3GLlTbCe1yJQLAUSI52/k8/PrzcZX5JwgwElUHN/SG+A==@lists.infradead.org, AJvYcCXoiSjX3KRMysbqNP0ZpDwWRF0ax78mXGjCDynT8Vz9Jcw9LNMI9uWln4JjfvmBiIMVxENvFF7nm756chMkLRE=@lists.infradead.org X-Gm-Message-State: AOJu0Yw66YLFnNetUvMCY39hVWErjUCCVRCWdnsgm8lNID6xVwb8w5Yk BsBP+nBQ1qw8L3QfkGIiyVjUaRHsKNt1kDAnN/fXMv6sFu/cqaN7rmn3 X-Gm-Gg: ASbGncvk7KKslD24fMBxBJJaA+e5I6CPvLyWNC0lmwcKFnVOVGDsfo9clZ5rARCCEfg 5KLrnAbeAdB/eRvkKMj/xwwvCHRlecZYryns5F8QK5xBaSvlg2CuaVTAVAWW2wsNOtoHJKLFWi7 NyIfPYs5eQ9L1hL7uufAWKPcfUzKONWel67VhdqW1NVKcKXKvwZOz7fnwuSADPoT8u9dgvaTP67 RfEk2lenTFNhFlm0dJ02O1Y+D46P32C5aWZuXhuB2BqVyXuKIUkhT7n91P9v76lMnYBw1+DM53Q qlKaFXiednSwrYk17FxYFYVsROsjRRPKbkyUPb7qKwpWW5oA3K+brWT0xq3jcdUti7YNQCts/tT MfWi3hz/5SRBrgXwAqdFlSa1DcKynuWBtYA746gc= X-Google-Smtp-Source: AGHT+IHR6aQlSF/8bXSoH4TD6ap2xoMQpmbGXXfb1yr3omEUKfVx4ptOTSMnNibgVm0ppSBcD6Zkmg== X-Received: by 2002:a05:6402:42c5:b0:618:4044:67a7 with SMTP id 4fb4d7f45d1cf-61840446cc7mr1952899a12.5.1754927966277; Mon, 11 Aug 2025 08:59:26 -0700 (PDT) Received: from giga-mm.home ([2a02:1210:8642:2b00:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-618200a0159sm2966360a12.6.2025.08.11.08.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 08:59:25 -0700 (PDT) Message-ID: <522ae36bf788df6d957bfee671857d6b2e1e8863.camel@gmail.com> Subject: Re: [PATCH 001/114] clk: at91: peripheral: fix return value From: Alexander Sverdlin To: bmasney@redhat.com, Michael Turquette , Stephen Boyd , Sudeep Holla , Cristian Marussi , Chen Wang , Inochi Amaoto , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Paul Cercueil , Keguang Zhang , Taichi Sugaya , Takao Orito , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Huang , Shan-Chun Hung , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Walmsley , Samuel Holland , Yixun Lan , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Michal Simek , Maxime Ripard , Andreas =?ISO-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Eugeniy Paltsev , Ray Jui , Scott Branden , Broadcom internal kernel review list , Max Filippov , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Palmer , Romain Perier , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Andrea della Porta , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Qin Jian , Viresh Kumar , Ulf Hansson , Luca Ceresoli , Alex Helms , Linus Walleij , Liviu Dudau , Lorenzo Pieralisi , Nobuhiro Iwamatsu Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sophgo@lists.linux.dev, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-actions@lists.infradead.org, asahi@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev Date: Mon, 11 Aug 2025 17:59:22 +0200 In-Reply-To: <20250811-clk-for-stephen-round-rate-v1-1-b3bf97b038dc@redhat.com> References: <20250811-clk-for-stephen-round-rate-v1-0-b3bf97b038dc@redhat.com> <20250811-clk-for-stephen-round-rate-v1-1-b3bf97b038dc@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250811_085928_135166_821F270D X-CRM114-Status: GOOD ( 18.45 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2025-08-11 at 11:17 -0400, Brian Masney via B4 Relay wrote: > From: Brian Masney >=20 > determine_rate() is expected to return an error code, or 0 on success. > clk_sam9x5_peripheral_determine_rate() has a branch that returns the > parent rate on a certain case. This is the behavior of round_rate(), > so let's go ahead and fix this by setting req->rate. >=20 > Fixes: b4c115c76184f ("clk: at91: clk-peripheral: add support for changea= ble parent rate") > Signed-off-by: Brian Masney Reviewed-by: Alexander Sverdlin > --- > =C2=A0drivers/clk/at91/clk-peripheral.c | 7 +++++-- > =C2=A01 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/clk/at91/clk-peripheral.c b/drivers/clk/at91/clk-per= ipheral.c > index c173a44c800aa8cc6970c266995f4a60b0a38554..629f050a855aaebfd1a03ff87= c2b016cd2284a5a 100644 > --- a/drivers/clk/at91/clk-peripheral.c > +++ b/drivers/clk/at91/clk-peripheral.c > @@ -279,8 +279,11 @@ static int clk_sam9x5_peripheral_determine_rate(stru= ct clk_hw *hw, > =C2=A0 long best_diff =3D LONG_MIN; > =C2=A0 u32 shift; > =C2=A0 > - if (periph->id < PERIPHERAL_ID_MIN || !periph->range.max) > - return parent_rate; > + if (periph->id < PERIPHERAL_ID_MIN || !periph->range.max) { > + req->rate =3D parent_rate; > + > + return 0; > + } > =C2=A0 > =C2=A0 /* Fist step: check the available dividers. */ > =C2=A0 for (shift =3D 0; shift <=3D PERIPHERAL_MAX_SHIFT; shift++) { --=20 Alexander Sverdlin.