From: Axe Yang <axe.yang@mediatek.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
Satya Tangirala <satyat@google.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
"Lucas Stach" <dev@lynxeye.de>,
Eric Biggers <ebiggers@google.com>,
Andrew Jeffery <andrew@aj.id.au>,
Stephen Boyd <swboyd@chromium.org>,
Kiwoong Kim <kwmad.kim@samsung.com>, Yue Hu <huyue2@yulong.com>,
Tian Tao <tiantao6@hisilicon.com>, <linux-mmc@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2 3/3] mmc: mediatek: add support for SDIO eint irq
Date: Fri, 14 Jan 2022 11:06:36 +0800 [thread overview]
Message-ID: <52901ebe0db555f8e58dc0d59cfd703c5a0fc2de.camel@mediatek.com> (raw)
In-Reply-To: <YeADWXPGPW253ssR@smile.fi.intel.com>
On Thu, 2022-01-13 at 12:47 +0200, Andy Shevchenko wrote:
> On Thu, Jan 13, 2022 at 03:58:52PM +0800, Axe Yang wrote:
>
> > But for the comment for 'dev_dbg', can you explain more about that?
>
> Sure.
>
> > On Tue, 2022-01-11 at 13:46 +0200, Andy Shevchenko wrote:
> > > On Tue, Jan 11, 2022 at 09:40:46AM +0800, Axe Yang wrote:
>
> ..
>
> > > > + host->pins_eint = pinctrl_lookup_state(host-
> > > > >pinctrl,
> > > > "state_eint");
> > > > + if (IS_ERR(host->pins_eint)) {
> > > > + dev_dbg(&pdev->dev, "Cannot find
> > > > pinctrl
> > > > eint!\n");
> > >
> > > In debug mode of pin control this will bring a duplicate message.
> >
> > Can you explain more about this comment?
> > I don't understand what the 'duplicate message' refers for.
>
> Have you chance to read the implementation of pinctrl_lookup_state()?
I have read pinctrl_lookup_state(), and if the 'duplicate message' you
were talking about is 'using pinctrl dummy state...':
https://elixir.bootlin.com/linux/latest/source/drivers/pinctrl/core.c#L1214
No, this message will not appear in debug mode if pins_eint not found
because pinctrl_dummy_state is always FALSE. MTK Soc do not need dummy
state support.
--
Best Regard,
Axe Yang
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2022-01-14 3:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 1:40 [PATCH v2 0/3]mmc: mediatek: add support for SDIO async irq Axe Yang
2022-01-11 1:40 ` [PATCH v2 1/3] dt-bindings: mmc: add cap-sdio-async-irq flag Axe Yang
2022-01-11 1:40 ` [PATCH v2 2/3] mmc: core: Add support for SDIO async interrupt Axe Yang
2022-01-11 1:40 ` [PATCH v2 3/3] mmc: mediatek: add support for SDIO eint irq Axe Yang
2022-01-11 11:46 ` Andy Shevchenko
2022-01-13 7:58 ` Axe Yang
2022-01-13 10:47 ` Andy Shevchenko
2022-01-14 3:06 ` Axe Yang [this message]
2022-01-14 13:38 ` Andy Shevchenko
2022-01-17 7:35 ` Axe Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52901ebe0db555f8e58dc0d59cfd703c5a0fc2de.camel@mediatek.com \
--to=axe.yang@mediatek.com \
--cc=adrian.hunter@intel.com \
--cc=andrew@aj.id.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chaotian.jing@mediatek.com \
--cc=dev@lynxeye.de \
--cc=devicetree@vger.kernel.org \
--cc=ebiggers@google.com \
--cc=huyue2@yulong.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=satyat@google.com \
--cc=swboyd@chromium.org \
--cc=tiantao6@hisilicon.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).