From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 867B3C77B7C for ; Fri, 26 May 2023 08:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LHm1nPppdaZSj1cUtyZFDUQUhbCN78UlFCNbQLE36jk=; b=cqQRt3HYX3toRS3HDMEhTTRbz0 pqILeRfLMH0HgGeitgXe093pu3wgG8cONcFnryaT0cD1eXZlSrpFmN9Pt37ImiwhsH1h1HFxCsvMU TtNfDsLXBuScJFUaFYOD9tKeJ3ljcO22IcEQ8RybSZlNz+HXUKjRon+9YJCvA6zZABvXm8QrWDWt1 KYjkTmAXisQItjWsGOhZ2W0KpboQtR3RCCDb+jt9YhCaIcaII+yWqGN16vUmrAeqPyuT2uXGUed6S Onuxd7pR6w+1ZSq9vgQuBPB6ukNWbSsTixZNUxGz6Sob/w7xhzX89zMEJ78Bw9eNxKICCaF0CvtEZ bbO8T+LA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q2T2A-001dxG-0a; Fri, 26 May 2023 08:42:50 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2T25-001dvC-2m; Fri, 26 May 2023 08:42:47 +0000 Received: from [IPV6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab] (unknown [IPv6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id BBF7E6606E87; Fri, 26 May 2023 09:42:43 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1685090564; bh=BNXanvyep5uBi6HyQ6HtMJheZQ49LWV8bcssg3dk5Ok=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=monxsZb1jFoOfAva4Maz69K5HYQAK5M2i3PjAjre83bOc3jlL/vQBm/0OgDIZO7aV uQcpW8/4KFqp06+S2hSO2lJpiAC+T5i06BOBWZTEAqkJt1ddf+a9SHpKwm1C0aePs8 FUEE5r2Z1qiRx/IulDxmqFkiGT5uT270F9euJHJewsnkx3GjZQA4oa1rNrrAjDn4tU +QXwFSj3adBl7PBJQ7CGxDs+67OTfceKMr5jAb/W/1E6MZYpKjpQKfUOmSh4uLsp5Z uBkZvzzlwEggr0P2xzyKsQByKDBoJTLdDc0VZBfX+t2aHu/l/7Elhzzy+KV/jIIVJc oOv/81XHyDxyw== Message-ID: <52dc6b40-9676-6e6c-de5c-5fad40e432ab@collabora.com> Date: Fri, 26 May 2023 10:42:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v4 06/11] drm/mediatek: gamma: Use bitfield macros Content-Language: en-US To: =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , "chunkuang.hu@kernel.org" Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "wenst@chromium.org" , =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "kernel@collabora.com" , "dri-devel@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" References: <20230518104857.124265-1-angelogioacchino.delregno@collabora.com> <20230518104857.124265-7-angelogioacchino.delregno@collabora.com> <069cbd4c325949e4662cec2d8547b6fcd111faf6.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <069cbd4c325949e4662cec2d8547b6fcd111faf6.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230526_014246_030535_1FCD3429 X-CRM114-Status: GOOD ( 16.58 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 26/05/23 07:32, CK Hu (胡俊光) ha scritto: > Hi, Angelo: > > On Thu, 2023-05-18 at 12:48 +0200, AngeloGioacchino Del Regno wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> Make the code more robust and improve readability by using bitfield >> macros instead of open coding bit operations. >> While at it, also add a definition for LUT_BITS_DEFAULT. >> >> Signed-off-by: AngeloGioacchino Del Regno < >> angelogioacchino.delregno@collabora.com> >> Reviewed-by: Jason-JH.Lin >> --- >> drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 41 ++++++++++++++------- >> -- >> 1 file changed, 26 insertions(+), 15 deletions(-) >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c >> b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c >> index 1592614b6de7..ed2aa1fb0171 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c >> +++ b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c >> @@ -3,6 +3,7 @@ >> * Copyright (c) 2021 MediaTek Inc. >> */ >> >> +#include >> #include >> #include >> #include >> @@ -22,9 +23,16 @@ >> #define GAMMA_LUT_EN BIT(1) >> #define >> GAMMA_DITHERING BIT(2) >> #define DISP_GAMMA_SIZE 0x0030 >> +#define DISP_GAMMA_SIZE_HSIZE GENMASK(28, >> 16) >> +#define DISP_GAMMA_SIZE_VSIZE GENMASK(12, >> 0) >> #define DISP_GAMMA_LUT 0x0700 >> >> +#define DISP_GAMMA_LUT_10BIT_R GENMASK(29, 20) >> +#define DISP_GAMMA_LUT_10BIT_G GENMASK(19, 10) >> +#define DISP_GAMMA_LUT_10BIT_B GENMASK(9, 0) >> + >> #define LUT_10BIT_MASK 0x03ff >> +#define LUT_BITS_DEFAULT 10 > > This is used only for AAL after patch "drm/mediatek: gamma: Support > specifying number of bits per LUT component", so I would like move AAL > definition to AAL driver and pass it to gamma driver. > Like LUT_SIZE_DEFAULT, this definition is not only for AAL but also for the older gamma lut register layout. In any case, I'll check if there's any clean way to pass AAL's gamma size to this driver... it's a different "component", so this may get complicated. Let's see what I can come up with in v5... Thanks, Angelo