Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Luca Leonardo Scorcia <l.scorcia@gmail.com>
Cc: linux-mediatek@lists.infradead.org,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	CK Hu <ck.hu@mediatek.com>, Jitao shi <jitao.shi@mediatek.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] dt-bindings: display: mediatek: dpi: Add compatible for mt8167
Date: Tue, 17 Nov 2026 16:09:35 +0100	[thread overview]
Message-ID: <53298044-3595-4231-a498-d78052799727@kernel.org> (raw)
In-Reply-To: <CAORyz2+wF=VDTFkRFU7jBu-zNTW7T8mnPrJZAj8ZVD-Yyr2b6A@mail.gmail.com>

On 17/11/2026 14:26, Luca Leonardo Scorcia wrote:
>> Turns out you bring here undocumented ABI. NAK.
> 
> Hi, I'm sorry but I don't see the relation between this commit you
> just NAKed and the bigger issue about mediatek-drm alias usage. It's
> not like I'm introducing anything new in these DPI specific patches
> and the individual display block drivers do not depend on the aliases
> (they're used by mediatek-drm for building the pipeline).

To clarify: you do introduce a new compatible here and in the DTS. Here
it is documented. This is correct.

However your DTS introduces also new usage of the ABI - aliases - and
that part is not documented. New DTS cannot use undocumented ABI. This
means that the binding was not complete. There is a mismatch or missing
pieces between the binding and DTS.

> 
> I understand why the commit to the dtsi that includes the aliases is
> NAKed, and the eventual fix is going to require a change in all of
> Mediatek SoCs dtsi. I am fine with the dtsi changes being blocked
> until an appropriate solution is found. I just don't understand the
> NAKs on the DPI components.

Because this binding in relation to your DTS is incomplete. Of course if
you drop the aliases from your DTS and this will be your final and
working solution (bindings and DTS should be complete) then this NAK is
not relevant and can be ignored. But in current form your bindings are
incomplete and DTS after correcting won't work...

Best regards,
Krzysztof


  reply	other threads:[~2026-11-17 15:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 11:38 [PATCH v2 0/4] Add support for the mt8167 display pipeline Luca Leonardo Scorcia
2026-09-21 11:38 ` [PATCH v2 1/4] dt-bindings: display: mediatek: dpi: Add compatible for mt8167 Luca Leonardo Scorcia
2026-09-25 13:24   ` Krzysztof Kozlowski
2026-11-17 12:52     ` Krzysztof Kozlowski
2026-11-16 15:01   ` Chun-Kuang Hu
2026-11-17 12:52   ` Krzysztof Kozlowski
2026-11-17 13:26     ` Luca Leonardo Scorcia
2026-11-17 15:09       ` Krzysztof Kozlowski [this message]
2026-09-21 11:38 ` [PATCH v2 2/4] drm/mediatek: Add support for mt8167 Digital Parallel Interface Luca Leonardo Scorcia
2026-11-16 15:05   ` Chun-Kuang Hu
2026-09-21 11:38 ` [PATCH v2 3/4] soc: mediatek: mt8167-mmsys: add routes for all display paths Luca Leonardo Scorcia
2026-09-21 11:38 ` [PATCH v2 4/4] arm64: dts: mediatek: mt8167: Add DRM nodes Luca Leonardo Scorcia
2026-11-17 12:35   ` Krzysztof Kozlowski
2026-11-17 12:53     ` AngeloGioacchino Del Regno
2026-11-17 12:55       ` Krzysztof Kozlowski
2026-11-17 13:00         ` AngeloGioacchino Del Regno
2026-11-17 13:12           ` Krzysztof Kozlowski
2026-11-17 14:21             ` AngeloGioacchino Del Regno
2026-11-17 16:00               ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53298044-3595-4231-a498-d78052799727@kernel.org \
    --to=krzk@kernel.org \
    --cc=airlied@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=ck.hu@mediatek.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jitao.shi@mediatek.com \
    --cc=krzk+dt@kernel.org \
    --cc=l.scorcia@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox