From: "Haozhe Chang (常浩哲)" <Haozhe.Chang@mediatek.com>
To: "loic.poulain@linaro.org" <loic.poulain@linaro.org>
Cc: "stephan@gerhold.net" <stephan@gerhold.net>,
"oneukum@suse.com" <oneukum@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"linuxwwan@intel.com" <linuxwwan@intel.com>,
"m.chetan.kumar@intel.com" <m.chetan.kumar@intel.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Hua Yang (杨华)" <Hua.Yang@mediatek.com>,
"chiranjeevi.rapolu@linux.intel.com"
<chiranjeevi.rapolu@linux.intel.com>,
"Haijun Liu (刘海军)" <haijun.liu@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"ryazanov.s.a@gmail.com" <ryazanov.s.a@gmail.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"Xiayu Zhang (张夏宇)" <Xiayu.Zhang@mediatek.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"chandrashekar.devegowda@intel.com"
<chandrashekar.devegowda@intel.com>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"shangxiaojing@huawei.com" <shangxiaojing@huawei.com>,
"Lambert Wang (王伟)" <Lambert.Wang@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"ricardo.martinez@linux.intel.com"
<ricardo.martinez@linux.intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v5] wwan: core: Support slicing in port TX flow of WWAN subsystem
Date: Wed, 14 Dec 2022 08:25:30 +0000 [thread overview]
Message-ID: <54c37c8f8eb7f35e4bb983b9104bd232758bae7b.camel@mediatek.com> (raw)
In-Reply-To: <CAMZdPi9JOQpmhQepBMeG5jzncP8t5mp68O2nfSOFUUZ9e_fDsQ@mail.gmail.com>
HI Loic
On Thu, 2022-12-01 at 10:56 +0100, Loic Poulain wrote:
> On Thu, 24 Nov 2022 at 08:47, <haozhe.chang@mediatek.com> wrote:
> >
> > From: haozhe chang <haozhe.chang@mediatek.com>
> >
> > wwan_port_fops_write inputs the SKB parameter to the TX callback of
> > the WWAN device driver. However, the WWAN device (e.g., t7xx) may
> > have an MTU less than the size of SKB, causing the TX buffer to be
> > sliced and copied once more in the WWAN device driver.
> >
> > This patch implements the slicing in the WWAN subsystem and gives
> > the WWAN devices driver the option to slice(by frag_len) or not. By
> > doing so, the additional memory copy is reduced.
> >
> > Meanwhile, this patch gives WWAN devices driver the option to
> > reserve
> > headroom in fragments for the device-specific metadata.
> >
> > Signed-off-by: haozhe chang <haozhe.chang@mediatek.com>
>
> Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
I have submitted patch V6 to add a reviewer, do you have any other
suggestions about the patch?
next prev parent reply other threads:[~2022-12-14 8:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 7:47 [PATCH v5] wwan: core: Support slicing in port TX flow of WWAN subsystem haozhe.chang
2022-12-01 9:56 ` Loic Poulain
2022-12-14 8:25 ` Haozhe Chang (常浩哲) [this message]
2022-12-14 9:10 ` Loic Poulain
2023-03-03 8:59 ` 回复: " Haozhe Chang (常浩哲)
2023-03-06 16:00 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54c37c8f8eb7f35e4bb983b9104bd232758bae7b.camel@mediatek.com \
--to=haozhe.chang@mediatek.com \
--cc=Hua.Yang@mediatek.com \
--cc=Lambert.Wang@mediatek.com \
--cc=Xiayu.Zhang@mediatek.com \
--cc=chandrashekar.devegowda@intel.com \
--cc=chiranjeevi.rapolu@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=haijun.liu@mediatek.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxwwan@intel.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
--cc=ricardo.martinez@linux.intel.com \
--cc=ryazanov.s.a@gmail.com \
--cc=shangxiaojing@huawei.com \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox