From: Mathias Nyman <mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Oliver Neukum <oneukum-IBi9RG/b67k@public.gmane.org>
Cc: chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] xhci: create one unified function to calculate TRB TD remainder.
Date: Tue, 08 Sep 2015 15:21:43 +0300 [thread overview]
Message-ID: <55EED2D7.6090308@linux.intel.com> (raw)
In-Reply-To: <1441712798.26994.41.camel-IBi9RG/b67k@public.gmane.org>
On 08.09.2015 14:46, Oliver Neukum wrote:
> On Tue, 2015-09-08 at 14:09 +0300, Mathias Nyman wrote:
>> Now Mediatek host has an additional quirk on how it uses the TD Size
>> field for remaining data. To prevent yet another function for
>> calculating
>> remainder we instead want to make one quirk friendly unified function.
>
> Could you clarify whether this replaces an existing quirk
> or renders unnecessary the introduction of a new quirk,
> because that decides whether this patch must go into stable.
>
Neither :)
This patch will simplify the quirk Mediatek wants to include in their patchseries.
After this patch the TD size part of the mediatek quirk can be reduced to maybe
a couple lines in total.
Yet another version of the Mediatek patcheries will be needed after this, but it will
be 50 - 100 lines shorter.
This patch is basically just code refactoring, enabling easier quirking.
It seems I need to do some rewording of the commit message of this patch as well
-Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-09-08 12:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 6:17 [PATCH v7 0/5] Mediatek xHCI support Chunfeng Yun
2015-09-08 6:17 ` [PATCH v7 1/5] dt-bindings: Add usb3.0 phy binding for MT65xx SoCs Chunfeng Yun
[not found] ` <1441693083-8440-2-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-09-09 0:16 ` Rob Herring
[not found] ` <55EF7A70.1080701-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-09-11 3:34 ` chunfeng yun
2015-09-09 13:58 ` Rob Herring
[not found] ` <1441693083-8440-1-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-09-08 6:18 ` [PATCH v7 2/5] dt-bindings: Add a binding for Mediatek xHCI host controller Chunfeng Yun
[not found] ` <1441693083-8440-3-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-09-09 0:30 ` Rob Herring
[not found] ` <55EF7DB0.7040607-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-09-11 3:39 ` chunfeng yun
2015-09-08 6:18 ` [PATCH v7 3/5] usb: phy: add usb3.0 phy driver for mt65xx SoCs Chunfeng Yun
2015-09-08 6:18 ` [PATCH v7 4/5] xhci: mediatek: support MTK xHCI host controller Chunfeng Yun
[not found] ` <1441693083-8440-5-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-09-08 10:45 ` Mathias Nyman
[not found] ` <55EEBC33.5030906-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-08 11:09 ` [PATCH] xhci: create one unified function to calculate TRB TD remainder Mathias Nyman
[not found] ` <1441710591-4267-1-git-send-email-mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-08 11:46 ` Oliver Neukum
[not found] ` <1441712798.26994.41.camel-IBi9RG/b67k@public.gmane.org>
2015-09-08 12:21 ` Mathias Nyman [this message]
2015-09-11 4:08 ` chunfeng yun
2015-10-06 13:48 ` Mathias Nyman
2015-09-11 4:30 ` chunfeng yun
2015-09-11 9:54 ` chunfeng yun
2015-09-08 6:18 ` [PATCH v7 5/5] arm64: dts: mediatek: add xHCI & usb phy for mt8173 Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EED2D7.6090308@linux.intel.com \
--to=mathias.nyman-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oneukum-IBi9RG/b67k@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).