From: Andrew Lunn <andrew@lunn.ch>
To: Aleksei Sviridkin <f@lex.la>
Cc: "Chester A . Unal" <chester.a.unal@arinc9.com>,
Daniel Golle <daniel@makrotopia.org>,
Vladimir Oltean <olteanv@gmail.com>, Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
Qingfang Deng <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net v2 1/2] net: dsa: mt7530: populate lpi_interfaces to fix EEE support
Date: Thu, 27 Aug 2026 20:13:01 +0200 [thread overview]
Message-ID: <55dbbbcf-f3b2-4e2d-bc3b-78fb0be4d843@lunn.ch> (raw)
In-Reply-To: <20260824024117.46154-2-f@lex.la>
On Mon, Aug 24, 2026 at 05:41:16AM +0300, Aleksei Sviridkin wrote:
> mt753x_phylink_get_caps() fills in lpi_capabilities and
> lpi_timer_default but never lpi_interfaces, so phylink treats the MAC
> as not supporting EEE: ethtool reports "Not supported" and
> phy_disable_eee() keeps userspace locked out. That undoes what
> commit 06dfcd4098cf ("net: dsa: mt7530: fix enabling EEE on MT7531
> switch on all boards") arranged: EEE off by default, but enableable
> with ethtool.
>
> Copy the supported interfaces into lpi_interfaces after
> mac_port_get_caps() has populated them, and leave the speeds above
> 1 Gbps out for now: drop 2500BASE-X from the copy, drop MAC_2500FD
Blah, blah, blah.
Please assume i can read the patch and understand what it does.
The commit message is about answering the question "Why?". That you
often cannot see from the code.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2026-08-27 18:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 2:41 [PATCH net v2 0/2] net: restore EEE on MediaTek switches and SoC MACs Aleksei Sviridkin
2026-08-24 2:41 ` [PATCH net v2 1/2] net: dsa: mt7530: populate lpi_interfaces to fix EEE support Aleksei Sviridkin
2026-08-27 18:13 ` Andrew Lunn [this message]
2026-08-24 2:41 ` [PATCH net v2 2/2] net: ethernet: mtk_eth_soc: " Aleksei Sviridkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55dbbbcf-f3b2-4e2d-bc3b-78fb0be4d843@lunn.ch \
--to=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chester.a.unal@arinc9.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f@lex.la \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox