From: John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
To: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V3 08/11] soc: mediatek: PMIC wrap: remove pwrap_is_mt8135() and pwrap_is_mt8173()
Date: Mon, 1 Feb 2016 12:15:19 +0100 [thread overview]
Message-ID: <56AF3E47.9010001@openwrt.org> (raw)
In-Reply-To: <56AF3D67.8080708-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 01/02/2016 12:11, Matthias Brugger wrote:
>
>
> On 01/02/16 12:00, John Crispin wrote:
>>
>>
>> On 01/02/2016 11:55, Matthias Brugger wrote:
>>>
>>>
>>> On 25/01/16 10:53, John Crispin wrote:
>>>> With ore SoCs being added the list of helper functions like these would
>>>
>>> The commit message is something strange:
>>> "With every new SoC being added..." maybe?
>>>
>>>> grow. While at it also add a new flag "bridge" and use that insted of
>>>
>>> s/insted/instead
>>>
>>>> pwrap_is_mt8173() where appropriate.
>>
>> you are lookign at V3 of the series, V4 has this fix done already
>>
>> [...]
>>
>>
>>>> }
>>>> @@ -830,6 +824,7 @@ static struct pmic_wrapper_type pwrap_mt8135 = {
>>>> .int_en_all = BIT(31) | BIT(1),
>>>> .spi_w = PWRAP_MAN_CMD_SPI_WRITE,
>>>> .wdt_src = PWRAP_WDT_SRC_MASK_ALL,
>>>> + .has_bridge = 1,
>>>> .init_reg_clock = pwrap_mt8135_init_reg_clock,
>>>> .init_special = pwrap_mt8135_init_special,
>>>> };
>>>
>>> Please set has_bridge explicitly for mt8173.
>>
>> I dont get it. the original code never did that.
>>
>
> has_bridge was introduced by this patch, but you don't set it explicitly
> to 0 in pwrap_mt8173.
>
> Just as I see it, please try to write a summary to every new version of
> a patch set which explains what you changed between one version and
> another. This will help a lot making the review easier.
>
> Thanks,
> Matthias
>
You missed the "to zero" part before. now the comment makes sense. I can
set it to 0 if it is more obvious for you in that case.
general consent is to not declare statics to 0. check_patch.pl will
actually complain about those declarations. that is why i was confused.
John
next prev parent reply other threads:[~2016-02-01 11:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 9:53 [PATCH V3 00/11] soc: mediatek: PMIC wrap: add MT6323/2701/7623 support John Crispin
2016-01-25 9:53 ` [PATCH V3 01/11] dt-bindings: ARM: Mediatek: add MT2701/7623 string to the PMIC wrapper doc John Crispin
[not found] ` <1453715604-36856-2-git-send-email-blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2016-01-26 2:44 ` Rob Herring
2016-01-25 9:53 ` [PATCH V3 02/11] soc: mediatek: PMIC wrap: don't duplicate the wrapper data John Crispin
2016-01-25 9:53 ` [PATCH V3 03/11] soc: mediatek: PMIC wrap: add wrapper callbacks for init_reg_clock John Crispin
2016-01-25 9:53 ` [PATCH V3 04/11] soc: mediatek: PMIC wrap: split SoC specific init into callback John Crispin
2016-02-01 10:43 ` Matthias Brugger
2016-01-25 9:53 ` [PATCH V3 05/11] soc: mediatek: PMIC wrap: WRAP_INT_EN needs a different bitmask for MT2701/7623 John Crispin
2016-02-01 10:48 ` Matthias Brugger
2016-01-25 9:53 ` [PATCH V3 06/11] soc: mediatek: PMIC wrap:: SPI_WRITE " John Crispin
2016-01-26 12:46 ` Yingjoe Chen
2016-01-25 9:53 ` [PATCH V3 07/11] soc: mediatek: PMIC wrap: move wdt_src into the pmic_wrapper_type struct John Crispin
2016-01-25 9:53 ` [PATCH V3 08/11] soc: mediatek: PMIC wrap: remove pwrap_is_mt8135() and pwrap_is_mt8173() John Crispin
2016-01-26 12:53 ` Yingjoe Chen
2016-02-01 10:55 ` Matthias Brugger
[not found] ` <56AF3992.8020004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-01 11:00 ` John Crispin
[not found] ` <56AF3AC7.5040001-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2016-02-01 11:11 ` Matthias Brugger
[not found] ` <56AF3D67.8080708-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-01 11:15 ` John Crispin [this message]
[not found] ` <56AF3E47.9010001-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2016-02-01 11:27 ` Matthias Brugger
[not found] ` <56AF4138.5010004-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-04 9:36 ` Yingjoe Chen
2016-02-04 18:37 ` Matthias Brugger
2016-01-25 9:53 ` [PATCH V3 09/11] soc: mediatek: PMIC wrap: add a slave specific struct John Crispin
2016-01-26 9:31 ` Yingjoe Chen
2016-01-26 9:36 ` John Crispin
2016-02-01 11:02 ` Matthias Brugger
2016-01-25 9:53 ` [PATCH V3 10/11] soc: mediatek: PMIC wrap: add mt6323 slave support John Crispin
2016-01-25 9:53 ` [PATCH V3 11/11] soc: mediatek: PMIC wrap: add MT2701/7623 support John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AF3E47.9010001@openwrt.org \
--to=blogic-p3rkhjxn3npafugrpc6u6w@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).