From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Boris Brezillon
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
erin.lo-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org
Subject: Re: [RFCv2: PATCH 1/2] mtd: mediatek: device tree docs for MTK Smart Device Gen1 NAND
Date: Sat, 26 Mar 2016 14:38:31 -0400 [thread overview]
Message-ID: <56F6D727.8070001@linaro.org> (raw)
In-Reply-To: <20160322145258.44945c64@bbrezillon>
On 03/22/2016 09:52 AM, Boris Brezillon wrote:
>> > + compatible = "mediatek,mt2701-nfc";
>> > + reg = <0 0x1100d000 0 0x1000>;
>> > + interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_LOW>;
>> > + clocks = <&pericfg CLK_PERI_NFI>,
>> > + <&pericfg CLK_PERI_NFI_PAD>;
>> > + clock-names = "nfi_clk", "pad_clk";
>> > + nand-on-flash-bbt;
>> > + status = "disabled";
>> > + mediatek,ecc-controller = <&bch>;
> Now that 2 different drivers use the same way to link the ECC engine
> and the NAND controller we can think about defining a generic property
> (ecc-engine ?), and provide a generic framework.
>
> The generic framework part is not something I'm asking right now, but I
> think we should start using a generic property here.
>
we have done all the changes required for v3 except this one.
so please let me check my understanding before going ahead: are you suggesting
that we replace "mediatek,ecc-controller" for "ecc-engine" (even though this
generic property doesn't exist yet)?
and then afterwards, generate another patch-set set to define and document
"ecc-engine"?
next prev parent reply other threads:[~2016-03-26 18:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 13:32 [RFCv2 0/2] MTK Smart Device Gen1 NAND Driver Jorge Ramirez-Ortiz
[not found] ` <1458653560-2679-1-git-send-email-jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-22 13:32 ` [RFCv2: PATCH 1/2] mtd: mediatek: device tree docs for MTK Smart Device Gen1 NAND Jorge Ramirez-Ortiz
[not found] ` <1458653560-2679-2-git-send-email-jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-22 13:52 ` Boris Brezillon
2016-03-26 18:38 ` Jorge Ramirez-Ortiz [this message]
[not found] ` <56F6D727.8070001-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-29 7:58 ` Boris Brezillon
2016-03-31 12:41 ` Jorge Ramirez-Ortiz
2016-03-22 13:32 ` [RFCv2: PATCH 2/2] mtd: mediatek: driver " Jorge Ramirez-Ortiz
[not found] ` <1458653560-2679-3-git-send-email-jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-22 16:58 ` Boris Brezillon
2016-03-22 23:43 ` Jorge Ramirez-Ortiz
[not found] ` <56F1D891.8010603-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-23 8:41 ` Boris Brezillon
2016-03-23 12:44 ` Jorge Ramirez-Ortiz
2016-03-23 0:29 ` Jorge Ramirez-Ortiz
[not found] ` <56F1E378.3000107-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-23 8:26 ` Boris Brezillon
2016-03-22 13:47 ` [RFCv2 0/2] MTK Smart Device Gen1 NAND Driver Boris Brezillon
2016-03-22 14:08 ` Jorge Ramirez-Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F6D727.8070001@linaro.org \
--to=jorge.ramirez-ortiz-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=erin.lo-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).