From: Jorge Ramirez <jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: John Crispin <blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>,
xiaolei li <xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
erin.lo-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org
Subject: Re: [PATCH v4 2/2] mtd: mediatek: driver for MTK Smart Device Gen1 NAND
Date: Mon, 2 May 2016 07:38:40 -0400 [thread overview]
Message-ID: <57273C40.6000407@linaro.org> (raw)
In-Reply-To: <676c2485-e176-4182-2400-201074b36ca3-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
On 05/02/2016 02:13 AM, John Crispin wrote:
> Hi,
>
>> Your ecc-strength setting is wrong, because your nand device's OOB size
>> is not enough to store 24 bit ecc parity data.
>> For this nand, its ecc-strength is max 12 bit per 1024B for our
>> controller.
>> You can get the setting as mtk-nand DT Documentation description.
> i tried 12 aswell and it also gives an error. the problem with the
> documentation is that FDM is unknown to me.
>
>
>> Because the ecc-size and ecc-strength settings are optional, so if you
>> are not sure how to set them, you can remove the setting from DT file.
> tried that just now, the driver defaults to 12 and problem remains
can you send the boot log letting the driver use its own calculated values?
ie, just don't specify any of the controller optional values in the
device tree and let the driver calculate them for you.
Also instead of a read operation, can you try the oobtest?
you will have to insmod or modprobe "mtd_oobtest dev="
I don't have the spec for the MT7623 but maybe also worth checking the
configuration for the NFI_ACCON settings (timing control register).
next prev parent reply other threads:[~2016-05-02 11:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 16:17 [PATCH v4 0/2] MTK Smart Device Gen1 NAND Driver Jorge Ramirez-Ortiz
[not found] ` <1461946642-1842-1-git-send-email-jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-04-29 16:17 ` [PATCH v4 1/2] mtd: mediatek: device tree docs for MTK Smart Device Gen1 NAND Jorge Ramirez-Ortiz
[not found] ` <1461946642-1842-2-git-send-email-jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-06 13:38 ` Boris Brezillon
2016-05-10 11:57 ` Jorge Ramirez
[not found] ` <5731CCA5.5070603-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-10 12:22 ` Boris Brezillon
2016-04-29 16:17 ` [PATCH v4 2/2] mtd: mediatek: driver " Jorge Ramirez-Ortiz
[not found] ` <1461946642-1842-3-git-send-email-jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-01 7:32 ` John Crispin
[not found] ` <1462165406.8414.196.camel@mhfsdcap03>
2016-05-02 6:13 ` John Crispin
[not found] ` <676c2485-e176-4182-2400-201074b36ca3-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
2016-05-02 11:38 ` Jorge Ramirez [this message]
[not found] ` <57273C40.6000407-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-02 17:43 ` John Crispin
2016-05-10 12:13 ` Boris Brezillon
2016-05-10 14:37 ` Jorge Ramirez
[not found] ` <5731F22C.902-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-10 14:55 ` Boris Brezillon
2016-05-10 14:45 ` Jorge Ramirez
[not found] ` <5731F40B.801-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-10 14:59 ` Boris Brezillon
2016-05-10 15:18 ` Jorge Ramirez
2016-05-10 14:50 ` Jorge Ramirez
[not found] ` <5731F537.9040009-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-10 15:13 ` Boris Brezillon
2016-05-10 15:37 ` Jorge Ramirez
2016-05-10 14:53 ` Jorge Ramirez
[not found] ` <5731F5E3.3020607-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-10 18:14 ` Jorge Ramirez
[not found] ` <573224F5.4030003-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-10 18:19 ` Boris Brezillon
2016-05-10 14:53 ` Jorge Ramirez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57273C40.6000407@linaro.org \
--to=jorge.ramirez-ortiz-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org \
--cc=boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=erin.lo-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).