From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jorge Ramirez Subject: Re: [PATCH v4 2/2] mtd: mediatek: driver for MTK Smart Device Gen1 NAND Date: Tue, 10 May 2016 10:53:23 -0400 Message-ID: <5731F5E3.3020607@linaro.org> References: <1461946642-1842-1-git-send-email-jorge.ramirez-ortiz@linaro.org> <1461946642-1842-3-git-send-email-jorge.ramirez-ortiz@linaro.org> <20160510141335.442d3d7b@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160510141335.442d3d7b@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Boris Brezillon Cc: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, erin.lo-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, blogic-p3rKhJxN3npAfugRpC6u6w@public.gmane.org List-Id: linux-mediatek@lists.infradead.org On 05/10/2016 08:13 AM, Boris Brezillon wrote: >> + >> >+void mtk_ecc_disable(struct mtk_ecc *ecc, struct mtk_ecc_config *config) > If you save the mode somewhere in mtk_ecc (or just write in both ENC > and DEC registers), you won't need this extra config arg here. ok. > >> >+{ >> >+ enum mtk_ecc_codec codec = config->codec; >> >+ >> >+ mtk_ecc_codec_wait_idle(ecc, codec); >> >+ writew(0, ecc->regs + ECC_IRQ_REG(codec)); >> >+ writew(ECC_CODEC_DISABLE(codec), ecc->regs + ECC_CTL_REG(codec)); >> >+ up(&ecc->sem); >> >+} >> >+EXPORT_SYMBOL(mtk_ecc_disable);