From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04324C4345F for ; Fri, 19 Apr 2024 09:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=y576gXoPcjc3Y2FVL6fqBu3Gc7Q1+NXvtH+iYdNf3yU=; b=v4H/LNJNcq+ylCAE4jTmSqdXgk Ek4pm+DXdh7m3MoHJLxrPjlhzKRPF+3ng4chbev4EJL2g59wSQHN8vQ6XSHZK+qzNIgu12OMwfzIU PhB3y6U9D1M+gfjDQMWmnGSxM+o03/vRb4pCxbkNIgVJp+/QSVqC8sbHjDDTQjvSTDj3I3uyTeWWX Si9rqk829H/cFU9GR5C7j2Mg1x8A0NSfST/73ZQ3bRe6IevOo0TTAlP7+exS096Hwerqphvegg611 dXfK5CuF0lyplKbBVWeimm6MiaVfgEL03phT7VhMPllRoZ8GFNeX3bpauZ0Ao4cAKeOisJmrCFs8d GzTEj0pA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxkSW-000000054kM-2mrP; Fri, 19 Apr 2024 09:23:04 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rxkSS-000000054hv-0Yl5 for linux-mediatek@lists.infradead.org; Fri, 19 Apr 2024 09:23:03 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-418c0d83d18so13238235e9.0 for ; Fri, 19 Apr 2024 02:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1713518574; x=1714123374; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=y576gXoPcjc3Y2FVL6fqBu3Gc7Q1+NXvtH+iYdNf3yU=; b=DGEP9bm2iRdQrIBHnxiPh1XiJ0++epzxksBLDKddPwJrv3ed1dVVgNuBlmKPUIxmL/ DPkMnVH85o952oW1NZR6e38e6QcdyqTVXwvIcoxxzZ61fyZ1FeKOYlq0DTiILb4y2vTB yaFL9KiBWxW6r0rhIENljUv5qYkPg5vFF/CFb+/IL7K+treBpURohFEYhzSoPDU43loM DDHxk72H+LQRFXlbmTeTDfLY7qTp3c+R81xvDV6UHWJ2gCF8AcxkDvO8lG0AoI9zflnp VzXSGYQXpQubvba59XjtXUUFBdXFTulgX/P+by+E43b1zImXnya74MZRZ7USJVyen2+r LCJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713518574; x=1714123374; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y576gXoPcjc3Y2FVL6fqBu3Gc7Q1+NXvtH+iYdNf3yU=; b=aAlryHidC4TRpuey6nv/Sl7LnwGajefIG5XwVbGfyzYEUI4Fy2ZDFQhtWcf7doEvHs dJ0sD0iOZqPFQdDAI5lbjfe4cABYMXlyHmRwS2B4PSCLP23WnX+yksyY3iOtETro7KEo YfODEUhQp4xemt2gK5Goflmsu+XeDVPRAabFdfPRhvKYKx4t07F1yCH6/pMxLcuQt+id LFJtXjWThxUIGtsWF7a5aL7cR6uI09lSl743ypBNutE0LZp9KI2wv1NUNz/BcBrV7kIq efXYaI4yX0fElqpI5Gs8REut6k0p1w625wIzpfwEqP2UZ/7vNUovh+K51tEB2cuD85Q2 6+8w== X-Forwarded-Encrypted: i=1; AJvYcCUpc3hR+QJKh0a4BYWCfo7JaecfgkH15Ca+Ka6w3Ln21QhI9dn+YPQqthh+ykGiUeO/HtL+i5M7cNIZEzgl9mrxuK/DVw98vUNrx9Fd3r4+tCle X-Gm-Message-State: AOJu0YwN613H/BHLf+9hhToenKFpZVhuFx4C1qMaHGy2XpdNtei2Nipy 09AuMtsvnvsxvlmhF0ZIkH5Aw47pcWtJpyY63SLhPPMvSW7iZzvWDoONuHrCwD8= X-Google-Smtp-Source: AGHT+IGEMMwvqsWa1wBPlb1YxcuxGJHgk4ZlrLlGwj3TJU4+1nuQXEqo0CbuUtJgEODgebOizRMxsg== X-Received: by 2002:a05:600c:1d0f:b0:418:f6b7:a383 with SMTP id l15-20020a05600c1d0f00b00418f6b7a383mr990122wms.2.1713518574007; Fri, 19 Apr 2024 02:22:54 -0700 (PDT) Received: from [192.168.1.172] ([93.5.22.158]) by smtp.gmail.com with ESMTPSA id b10-20020a05600c4e0a00b00418f30874b4sm4015450wmq.17.2024.04.19.02.22.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Apr 2024 02:22:53 -0700 (PDT) Message-ID: <57705980-e776-4178-878d-15c2007f7ef3@baylibre.com> Date: Fri, 19 Apr 2024 11:22:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/17] drm/mediatek: add MT8365 SoC support To: AngeloGioacchino Del Regno , Chun-Kuang Hu , Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Jitao Shi , CK Hu , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Michael Turquette , Stephen Boyd , Fabien Parent , Markus Schneider-Pargmann , Catalin Marinas , Will Deacon Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org, linux-clk@vger.kernel.org References: <20231023-display-support-v3-0-53388f3ed34b@baylibre.com> <20231023-display-support-v3-14-53388f3ed34b@baylibre.com> <9ef43fff-ee2a-4b2c-a595-30f5bf7588c2@collabora.com> Content-Language: en-US From: Alexandre Mergnat In-Reply-To: <9ef43fff-ee2a-4b2c-a595-30f5bf7588c2@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240419_022300_181364_6E5E0E06 X-CRM114-Status: GOOD ( 23.37 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 19/04/2024 10:01, AngeloGioacchino Del Regno wrote: > Il 18/04/24 16:17, amergnat@baylibre.com ha scritto: >> From: Fabien Parent >> >> Add DRM support for MT8365 SoC. >> >> Signed-off-by: Fabien Parent >> Reviewed-by: AngeloGioacchino Del Regno >> Signed-off-by: Alexandre Mergnat > > There are two things that I want to point out. Please check below. > > The series that I've sent for adding OF Graphs [1] support to MediaTek DRM is > not going to be picked in time for v6.10, but I think neither your MT8365 support > series is, and that's why I'm telling you this. > > If your work was based off my series, you would not need to add the MT8365 ddp > MAIN and EXT paths to mtk_drm_drv: you'd just add it to the bindings and then > you would declare the paths in devicetree. Ok then I will rebase my v4 on top of your serie > > > [1]: https://lore.kernel.org/r/20240409120211.321153-1-angelogioacchino.delregno@collabora.com > > There's also one more comment.... > >> --- >>   drivers/gpu/drm/mediatek/mtk_drm_drv.c | 30 ++++++++++++++++++++++++++++++ >>   1 file changed, 30 insertions(+) >> >> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >> index 74832c213092..427b601309c4 100644 >> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > ..snip.. > >> @@ -793,6 +821,8 @@ static const struct of_device_id mtk_ddp_comp_dt_ids[] = { >>         .data = (void *)MTK_DSI }, >>       { .compatible = "mediatek,mt8188-dsi", >>         .data = (void *)MTK_DSI }, >> +    { .compatible = "mediatek,mt8365-dpi", > > You removed the mt8365 specific compatible from the DPI driver - why did you keep > it here?! that's not needed! :-) Sorry for that, I forgot to remove it in this driver too. Thanks to catched it. > > Cheers, > Angelo > >> +      .data = (void *)MTK_DPI }, >>       { } >>   }; >> > -- Regards, Alexandre