Re: [PATCH v3 04/12] drm/mediatek: extract common functions from the mtk hdmi driver

AngeloGioacchino Del Regno
2022-11-07T11:10:05Z

Il 04/11/22 15:09, Guillaume Ranquet ha scritto:
> Create a common "framework" that can be used to add support for
> different hdmi IPs within the mediatek range of products.
>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> ---
> drivers/gpu/drm/mediatek/Makefile | 3 +-
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 620 ++---------------------------
> drivers/gpu/drm/mediatek/mtk_hdmi.h | 16 +
> drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 433 ++++++++++++++++++++
> drivers/gpu/drm/mediatek/mtk_hdmi_common.h | 221 ++++++++++
> 5 files changed, 704 insertions(+), 589 deletions(-)
>

..snip..

> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c
> new file mode 100644
> index 000000000000..3f08d37b1af0
> --- /dev/null
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c

..snip..

> +
> +int mtk_hdmi_setup_avi_infoframe(struct mtk_hdmi *hdmi, u8 *buffer, size_t bufsz,
> + struct drm_display_mode *mode)

warning: no previous prototype for ‘mtk_hdmi_setup_avi_infoframe’
[-Wmissing-prototypes]

Please fix.

Thanks,
Angelo