From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Tinghan Shen <tinghan.shen@mediatek.com>
Cc: alsa-devel@alsa-project.org,
"Allen-KH Cheng" <Allen-KH.Cheng@mediatek.com>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Takashi Iwai" <tiwai@suse.com>,
kernel-janitors@vger.kernel.org,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Yang Yingliang" <yangyingliang@huawei.com>,
"Mark Brown" <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
"YC Hung" <yc.hung@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Daniel Baluta" <daniel.baluta@nxp.com>,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH] ASoC: SOF: mediatek: Fix error code in probe
Date: Wed, 15 Jun 2022 05:56:22 -0500 [thread overview]
Message-ID: <5e2f44f1-de41-ac02-9fa8-e26a849897ad@linux.intel.com> (raw)
In-Reply-To: <YqmWIK8sTj578OJP@kili>
On 6/15/22 03:19, Dan Carpenter wrote:
> This should return PTR_ERR() instead of IS_ERR().
>
> Fixes: e0100bfd383c ("ASoC: SOF: mediatek: Add mt8186 ipc support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Nice catch, thanks!
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> sound/soc/sof/mediatek/mt8186/mt8186.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/mediatek/mt8186/mt8186.c b/sound/soc/sof/mediatek/mt8186/mt8186.c
> index 3333a0634e29..e006532caf2f 100644
> --- a/sound/soc/sof/mediatek/mt8186/mt8186.c
> +++ b/sound/soc/sof/mediatek/mt8186/mt8186.c
> @@ -392,7 +392,7 @@ static int mt8186_dsp_probe(struct snd_sof_dev *sdev)
> PLATFORM_DEVID_NONE,
> pdev, sizeof(*pdev));
> if (IS_ERR(priv->ipc_dev)) {
> - ret = IS_ERR(priv->ipc_dev);
> + ret = PTR_ERR(priv->ipc_dev);
> dev_err(sdev->dev, "failed to create mtk-adsp-ipc device\n");
> goto err_adsp_off;
> }
next prev parent reply other threads:[~2022-06-15 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 8:19 [PATCH] ASoC: SOF: mediatek: Fix error code in probe Dan Carpenter
2022-06-15 9:52 ` Tinghan Shen
2022-06-15 10:56 ` Pierre-Louis Bossart [this message]
2022-06-15 12:01 ` Péter Ujfalusi
2022-06-15 17:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e2f44f1-de41-ac02-9fa8-e26a849897ad@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Allen-KH.Cheng@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tinghan.shen@mediatek.com \
--cc=tiwai@suse.com \
--cc=yangyingliang@huawei.com \
--cc=yc.hung@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox