Re: [PATCH net-next v4 1/5] net: phy: mediatek: Re-organize MediaTek ethernet phy drivers

["SkyLake Huang (黃啟澤)" <SkyLake.Huang@mediatek.com>]

On Tue, 2024-05-21 at 17:36 +0100, Simon Horman wrote:
> > diff --git a/drivers/net/phy/mediatek/Kconfig
> b/drivers/net/phy/mediatek/Kconfig
> > new file mode 100644
> > index 0000000..2fa3a78
> > --- /dev/null
> > +++ b/drivers/net/phy/mediatek/Kconfig
> > @@ -0,0 +1,22 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +config MEDIATEK_GE_PHY
> > +tristate "MediaTek Gigabit Ethernet PHYs"
> > +help
> > +  Supports the MediaTek non-built-in Gigabit Ethernet PHYs.
> > +
> > +  Non-built-in Gigabit Ethernet PHYs include mt7530/mt7531.
> > +  You may find mt7530 inside mt7621. This driver shares some
> > +  common operations with MediaTek SoC built-in Gigabit
> > +  Ethernet PHYs.
> > +
> > +config MEDIATEK_GE_SOC_PHY
> > +bool "MediaTek SoC Ethernet PHYs"
> 
> Hi,
> 
> This patch changes this kconfig option from tristate to bool.
> 
> This seems to break allmodconfig builds.
> 
> I think that is because MEDIATEK_GE_SOC_PHY is builtin while
> PHYLIB is a module, and this driver uses symbols from PHYLIB.
> 

Sorry this was my fault. I'll change it back to tristate in v5.

Sky