From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCC35C433F5 for ; Fri, 1 Oct 2021 03:27:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99C616134F for ; Fri, 1 Oct 2021 03:27:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 99C616134F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oFkslrUHVo0o8hEYI7wzqc1i3qb2YmWXWFX3A2voHYs=; b=Ve8bn+rFjEa26J NDokXXdfbl4C4wk19sJwPqW+efgi5dYbwEe+lEEaOyM+s39dQvTY9huvmyIdWrUUulQlxN7PW3M1v HSkHegq4jXKnk6al5eV7ib758QdKmeCPbd63J4ifCovjZwp3cFW58hop3rGBFSmxMhj+9YpDhdN3W KZcGVuZiy9QtHn2OimBXfYiDG5LLIjonH+AST72sipLKuKEHHGC+geeVhW2UuJvzuWNiPSJkdRqYL 3FuOkcYq53yAdlnG2UVUFJui/nsitDa+cUvD8CvGou5ZolpH7OaGI2GZFCdPsbl+J1buew6INC7Zs 6faI4lMYl6s5Q1zhwuiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mW9Cb-00GX5s-Ho; Fri, 01 Oct 2021 03:27:13 +0000 Received: from rtits2.realtek.com ([211.75.126.72] helo=rtits2.realtek.com.tw) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mW9CO-00GX2g-9e; Fri, 01 Oct 2021 03:27:01 +0000 Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.73 with qID 1913QnFD2004059, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36503.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.71/5.88) with ESMTPS id 1913QnFD2004059 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 1 Oct 2021 11:26:49 +0800 Received: from RTEXMBS05.realtek.com.tw (172.21.6.98) by RTEXH36503.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Fri, 1 Oct 2021 11:26:49 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS05.realtek.com.tw (172.21.6.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 1 Oct 2021 11:26:48 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::cdd5:82a3:e854:7098]) by RTEXMBS04.realtek.com.tw ([fe80::cdd5:82a3:e854:7098%5]) with mapi id 15.01.2106.013; Fri, 1 Oct 2021 11:26:48 +0800 From: Hayes Wang To: Alan Stern , Oliver Neukum CC: Jason-ch Chen , "matthias.bgg@gmail.com" , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , "Project_Global_Chrome_Upstream_Group@mediatek.com" , "hsinyi@google.com" , nic_swsd Subject: RE: [PATCH] r8152: stop submitting rx for -EPROTO Thread-Topic: [PATCH] r8152: stop submitting rx for -EPROTO Thread-Index: AQHXtPF6mRt31KuIqUSf0ySwz113xKu6nqYQ//+g0oCAAYwXgIAAYT6AgAFAzFCAAA04sA== Date: Fri, 1 Oct 2021 03:26:48 +0000 Message-ID: <5f56b21575dd4f64a3b46aac21151667@realtek.com> References: <20210929051812.3107-1-jason-ch.chen@mediatek.com> <4c2ad5e4a9747c59a55d92a8fa0c95df5821188f.camel@mediatek.com> <274ec862-86cf-9d83-7ea7-5786e30ca4a7@suse.com> <20210930151819.GC464826@rowland.harvard.edu> <3694347f29ed431e9f8f2c065b8df0a7@realtek.com> In-Reply-To: <3694347f29ed431e9f8f2c065b8df0a7@realtek.com> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.203] x-kse-serverinfo: RTEXMBS05.realtek.com.tw, 9 x-kse-attachmentfiltering-interceptor-info: no applicable attachment filtering rules found x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: =?us-ascii?Q?Clean,_bases:_2021/9/30_=3F=3F_10:00:00?= x-kse-bulkmessagesfiltering-scan-result: protection disabled MIME-Version: 1.0 X-KSE-ServerInfo: RTEXH36503.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_202700_489089_E6CFAD62 X-CRM114-Status: GOOD ( 13.91 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org > Alan Stern > [...] > > There has been some discussion about this in the past. > > > > In general, -EPROTO is almost always a non-recoverable error. > > Excuse me. I am confused about the above description. > I got -EPROTO before, when I debugged another issue. > However, the bulk transfer still worked after I resubmitted > the transfer. I didn't do anything to recover it. That is why > I do resubmission for -EPROTO. I check the Linux driver and the xHCI spec. The driver gets -EPROTO for bulk transfer, when the host returns COMP_USB_TRANSACTION_ERROR. According to the spec of xHCI, USB TRANSACTION ERROR means the host did not receive a valid response from the device (Timeout, CRC, Bad PID, unexpected NYET, etc.). It seems to be reasonable why resubmission sometimes works. Best Regards, Hayes _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek