Re: [V1,01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible

Kyrie Wu (吴晗)
2025-04-07T09:43:50Z

On Mon, 2025-04-07 at 09:19 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On 07/04/2025 09:13, Kyrie Wu (吴晗) wrote:
> > On Thu, 2025-01-09 at 14:54 +0100, Krzysztof Kozlowski wrote:
>
> ...
>
>
> > > >
> > > > properties:
> > > > compatible:
> > > > - const: mediatek,mt8195-jpgdec
> > > > + enum:
> > > > + - mediatek,mt8195-jpgdec
> > > > + - mediatek,mt8196-jpgdec
> > >
> > > Devices look compatible, so express it with fallback.
> > >
> > > Best regards,
> > > Krzysztof
> >
> > Dear Krzysztof,
> >
> > The MT8195 and MT8196 are both multi-hardware chips, I renamed the
> > file
> > to treat it as a common file, if I don't do that it will need to
> > recreate a file with similar contents. Is this acceptable?
>
> No, do not create own rules. I do not see how this is related to my
> comment at all.
>
> You responded three months after my review, so entire context
> including
> actual mails in my inbox are gone.
>
> If you disagree with feedback, respond in timely manner. I feel
> discussing something after three months like wasting my time.
>
>
> > If the above description is acceptable, I will apply your request
> > in
> > the next version.
>
> Best regards,
> Krzysztof

Dear Krzysztof,

I'm truly sorry for what I have done. I feel very ashamed and self-
blame after I tried to stand in your shoes.

You contributed a lot of time to help me review my patch, you could
have spent it with your family or your friends, and I failed you in
your selfless kindness. I have not only wasted your precious time but
also disrespected your contribution by ignoring your reply,
undoubtedly.

This was never my intention, and I‘m committed to improving my
communication and collaboration within the community. I value your
expertise and feedback, and I will ensure that I respond promptly and
thoughtfully to any future reviews. (I have improved my email
notifications, and I will share this experience within my team to
remind all developers.)

Thank you for your understanding and patience. I hope to rebuild your
trust and continue contributing positively to the community.

Sincerely,
Kyrie