Re: [PATCH v3 2/9] dt-bindings: mailbox: Add mboxes property for CMDQ secure driver

Conor Dooley
2023-12-22T15:07:28Z

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

On Fri, Dec 22, 2023 at 12:52:21PM +0800, Jason-JH.Lin wrote:
> Add mboxes to define a GCE loopping thread as a secure irq handler.

> This property is only required if CMDQ secure driver is supported.

What do drivers have to do with this? Either the mailbox channel exists
or it does not. That said, I am not sure why this should be in DT in the
first place, can't the driver for the mailbox controller reserve a
channel for its own use?

Thanks,
Conor.

>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> ---
> .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> index e4da0a58c943..0c17e1be99c2 100644
> --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> @@ -56,6 +56,9 @@ properties:
> include/dt-bindings/gce/<chip>-gce.h of each chips.
> $ref: /schemas/types.yaml#/definitions/uint32-array
>
> + mboxes:
> + maxItems: 1
> +
> required:
> - compatible
> - "#mbox-cells"
> --
> 2.18.0
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]