From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67DE9C4167B for ; Thu, 7 Dec 2023 17:04:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To:Subject :MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wIK0i4TzjdboGcUSVSsAnrSwQJ8ReNMyGt/OVRNCE2k=; b=yN9pVT3xvlyq3J GnEvw5SNAZJgVo+8QMBfpTPg1UlCwj9gPr9xGylfer5XCcAOXi56v0zU7MtEQnp3Et97xLIZIYxKh 54Ca/tTwHy+vxsI1Uc6BGPfefGNzJ10FZp2lZXawaCCuSmsJeAgRrV7MXX20xkpabFaEod7qot5rY RM1uA+tl2t8SB68gLhTJrmVA9ReBf7pGc3kNF9LAi8AdKvtg8cFTrvlpDTptWasssRrv5VuQv+s3p 8nl9JGX7p/aiBn+n3i1rpgHw7ltVGp2Zg95wNLdkA09tTGbp0YS7TC2lxsXIlK6SjvgDXPariiVNo VJSxL5al7DxJj760E99Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBHnP-00DUa3-0F; Thu, 07 Dec 2023 17:04:19 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBHnL-00DUXw-1c for linux-mediatek@lists.infradead.org; Thu, 07 Dec 2023 17:04:17 +0000 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-3333131e08dso1411644f8f.2 for ; Thu, 07 Dec 2023 09:04:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701968653; x=1702573453; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wIK0i4TzjdboGcUSVSsAnrSwQJ8ReNMyGt/OVRNCE2k=; b=hjTkpvl2WYd3bWZ0VIsz+xNKHWKfk1m9T9gQwBd5JsWXbLwKhRwtz86UxH21+XIObF iQre8uc1WrCmX7JIc61jjIhkOykCkvBoEzU+UnX66p6jrlubaVKTvhdcdBU03SQqph3Q 3jyGmhYZvA25gVNxor24wmxZUT0AtnsY6KWTmo9DgnTJVfJIobXO5/T+hh2UDBg+1a7X cyS1YwUfw5V/n3QQ0JNFZ2jAWTsYutycKc5O5LOk+9tnH81yk53PMLc12uw5ezyAwx4S Yw82uj+7Kgd7M3PV/8dcprhqAdvXOEYtc7luus4xVZqkMbNsTwBuB0T2l5S0Pj6wGE2G CKGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701968653; x=1702573453; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wIK0i4TzjdboGcUSVSsAnrSwQJ8ReNMyGt/OVRNCE2k=; b=wzrWV0qHnhwO1iBZVJAkShWHdabBNfcJFZEyR3YiMcI0X8657woFHAULA5oNI56Qp1 jJokSHJmHHYeJuzTSJ8rgzCE+CR7sgPQVZh1mwJY0T61xu/WzYSVJZxw08gLeTaGqx6V HoeX8RudTf1uSNQ6J5ew1kFOMP1HHNLahxfVkMsDf3gl1MsjvcEv4vc45rN2cFb+KD7r ZgSwIWAUffcgB1qAhGmWnUaDYkx+sXYAI3/H4h5sIYgLUah+UVfS8kjQJqlO9greyko2 6yIZWYR9+zfUg4EpdiGV5AeZnmNyKFYWzrgnRs5reIjOMAnc60a1RtbvBJh9kjl9PQFB 3wug== X-Gm-Message-State: AOJu0Yz1Vv6/A3dmi8ngEx+0/N85aR5DerdX/PHqRVu8vBU8clOg9zJh Lo6ge+RLpyVE0g8TF2fl34JhdQ== X-Google-Smtp-Source: AGHT+IHIKz0oA9x3+g76SEzo9UIbVaO2JrxPwmG1Hvcdjofzjv0HBTFxjn24wY3gV7tbvwTmdgs7Jw== X-Received: by 2002:a5d:5041:0:b0:333:2fd2:2f10 with SMTP id h1-20020a5d5041000000b003332fd22f10mr1527867wrt.137.1701968653173; Thu, 07 Dec 2023 09:04:13 -0800 (PST) Received: from [192.168.1.20] ([178.197.218.27]) by smtp.gmail.com with ESMTPSA id o12-20020a5d474c000000b003333dd777a4sm99632wrs.46.2023.12.07.09.03.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Dec 2023 09:04:12 -0800 (PST) Message-ID: <64ee48fc-4f77-48cc-b235-c9fb2b10afc4@linaro.org> Date: Thu, 7 Dec 2023 18:03:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] dt-bindings: clock: mediatek: add clock controllers of MT7988 Content-Language: en-US To: Daniel Golle , AngeloGioacchino Del Regno References: <23bc89d407e7797e97b703fa939b43bfe79296ce.1701823757.git.daniel@makrotopia.org> <3e72bff6-9f4d-4cd4-845e-b065f1233ec6@collabora.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231207_090415_566248_5311E4C9 X-CRM114-Status: GOOD ( 10.80 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Liao , devicetree@vger.kernel.org, Michael Turquette , Eric Dumazet , Krzysztof Kozlowski , linux-clk@vger.kernel.org, Dan Carpenter , Sabrina Dubroca , Chen-Yu Tsai , Jakub Kicinski , Paolo Abeni , "Garmin.Chang" , Conor Dooley , Sam Shih , Rob Herring , Jianhui Zhao , Matthias Brugger , linux-arm-kernel@lists.infradead.org, Stephen Boyd , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, "David S. Miller" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 06/12/2023 13:45, Daniel Golle wrote: >>> +properties: >>> + compatible: >>> + items: >>> + - const: mediatek,mt7988-ethwarp >>> + - const: syscon >>> + - const: simple-mfd >> >> No, this is not a mfd, I say. >> >> Prove me wrong! :-) > > https://github.com/dangowrt/linux/blob/mt7988-for-next/arch/arm64/boot/dts/mediatek/mt7988a.dtsi#L564 > > The 'simple-mfd' compatible is required to have the Linux > kernel probe drivers for sub-nodes -- several drivers will act on > the different aspects of the circuit exposed at this memory range. > From what I understand, this is the definition of a MFD. We know what is MFD, so no need to teach us. We expect you to look at this. You do not have subnodes, so MFD is pointless. Showing DTSI means nothing except that you did not test your bindings. Best regards, Krzysztof