From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88ECBC7619A for ; Wed, 22 Mar 2023 12:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ib3UWmZEnImrDMx++pWyzLfYKTUvb4CgMHIkVCfcUbY=; b=eJpiD1bE2wDuntV6ZomPpxOx9V OX8vzhoja9Mw3pLuAb7R7aaWeNex7e0UR12HcdAqdzz8Z3uAm40a20cfEaS+l0zYjsbvGMnSSmuPm Jwtn/UN+MBdH6JHgqnQVVivbXIppGD7wFTRNB7ODYwmVUyxfyo029CNClhIEGPh6HZ2U8zQDEJL6L PSgOKljR9on3ZF6K1CSfTf+hyxKA0kBC9LqnK91Jq49y2yRA+D7+wSArr+0kLKgUGtKb9RjjgLUEY vM2FIdK689Zf3G1bZZXdEw46kA8fzust+t8crNfLB3Vg2l/PmHzCyJiJNyurdXIOHlmqv+vvB50fF LAcnU+oA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pexKW-00FsuP-1C; Wed, 22 Mar 2023 12:12:36 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pexKR-00Fssn-25; Wed, 22 Mar 2023 12:12:33 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id C0D7F66018CB; Wed, 22 Mar 2023 12:12:26 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1679487147; bh=ZOtaZyVnu/uBtZEaZewxTNOHLS2qqXJGInNUpjI+hIA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZUNaB6uMVZimiXGmerDGwTb7om+tBBR/ewI16XEqa2Z/heAJ5OUIB1lmtrX+Dn0xW IPwyMi7ezC1Tx4Ft9mNmJ98n29+tfe9npY1Mpons7T0uU+3k2XW1jo4DimmW9fT5Qy 0+/d2irC6l91QqIEMijH/QAJAS1+Usj9aXUMiqYlcjbOIzqPqji4GItD951SgKnbV7 Li/Iik6D+BkpLzp69IrNtL/NPpdjcQ4Y4UITzOl6615blAbifAAByZWRpQhXZYK5jK Ih6FbIETmnYb20nOxD7JeE6Eet+HNptpwihq+/ESBHsj+Ffo9xGIOuuuS4u220q7Z7 PsN7bmSTzZLyQ== Message-ID: <66cb5a95-4646-87d1-0acf-ebd473f3c653@collabora.com> Date: Wed, 22 Mar 2023 13:12:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2,5/7] media: mediatek: vcodec: Get get each instance format type Content-Language: en-US To: Yunfei Dong , Chen-Yu Tsai , Nicolas Dufresne , Hans Verkuil , Benjamin Gaignard , =?UTF-8?Q?N=c3=adcolas_F_=2e_R_=2e_A_=2e_Prado?= Cc: Matthias Brugger , Hsin-Yi Wang , Fritz Koenig , Daniel Vetter , Steve Cho , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20230322094617.19410-1-yunfei.dong@mediatek.com> <20230322094617.19410-6-yunfei.dong@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230322094617.19410-6-yunfei.dong@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230322_051231_913024_D4E69902 X-CRM114-Status: GOOD ( 13.52 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 22/03/23 10:46, Yunfei Dong ha scritto: > Adding echo command to get capture and output queue format > type:'echo -format > vdec' > > Signed-off-by: Yunfei Dong > --- > .../mediatek/vcodec/mtk_vcodec_dbgfs.c | 48 +++++++++++++++++++ > .../mediatek/vcodec/mtk_vcodec_dbgfs.h | 1 + > 2 files changed, 49 insertions(+) > > diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.c > index 19a1dc068efd..1b1b4301a83d 100644 > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.c > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.c > @@ -10,6 +10,48 @@ > #include "mtk_vcodec_drv.h" > #include "mtk_vcodec_util.h" > > +static void mtk_vdec_dbgfs_get_format_type(struct mtk_vcodec_ctx *ctx, char *buf, > + int *used, int total) > +{ > + int curr_len; > + > + switch (ctx->current_codec) { > + case V4L2_PIX_FMT_H264_SLICE: > + curr_len = snprintf(buf + *used, total - *used, > + "\toutput format: h264 slice\n"); Isn't this the same information that's also given by the VIDIOC_ENUM_FMT ioctl? Check functions v4l_enum_fmt(), v4l_fill_fmtdesc(). Regards, Angelo