From: Christian Marangi <ansuelsmth@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: "Benjamin Larsson" <benjamin.larsson@genexis.eu>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Sean Wang" <sean.wang@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Lee Jones" <lee@kernel.org>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
upstream@airoha.com, linux-pwm@vger.kernel.org
Subject: Re: [PATCH v8 3/6] dt-bindings: pwm: airoha: Add EN7581 pwm
Date: Tue, 22 Oct 2024 23:12:08 +0200 [thread overview]
Message-ID: <6718152c.050a0220.3afab9.2d2b@mx.google.com> (raw)
In-Reply-To: <20241022210858.GA1565063-robh@kernel.org>
On Tue, Oct 22, 2024 at 04:08:58PM -0500, Rob Herring wrote:
> On Tue, Oct 22, 2024 at 10:02:05PM +0200, Benjamin Larsson wrote:
> > On 21/10/2024 21:00, Rob Herring wrote:
> > > > + airoha,sipo-clock-divisor:
> > > > + description: Declare Shift Register chip clock divisor (clock source is
> > > > + from SoC APB Clock)
> > > Where is the clock source defined?
> > >
> > By measurement the clock was found to be 125MHz.
>
> What I mean is the clock input should be a 'clocks' property. Assuming
> this is a clock input to the PWM which I'm not so sure about given the
> other replies.
>
Yep it's not, we are just dropping this property and hardcoding it to a
sensible value in the driver. Sorry for the confusion and thanks for the
clarification.
--
Ansuel
next prev parent reply other threads:[~2024-10-22 21:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 13:19 [PATCH v8 0/6] Add mfd, pinctrl and pwm support to EN7581 SoC Lorenzo Bianconi
2024-10-18 13:19 ` [PATCH v8 1/6] dt-bindings: arm: airoha: Add the chip-scu node for " Lorenzo Bianconi
2024-10-21 13:42 ` AngeloGioacchino Del Regno
2024-10-18 13:19 ` [PATCH v8 2/6] dt-bindings: pinctrl: airoha: Add EN7581 pinctrl Lorenzo Bianconi
2024-10-21 13:42 ` AngeloGioacchino Del Regno
2024-10-18 13:19 ` [PATCH v8 3/6] dt-bindings: pwm: airoha: Add EN7581 pwm Lorenzo Bianconi
2024-10-21 13:42 ` AngeloGioacchino Del Regno
2024-10-21 19:00 ` Rob Herring
2024-10-22 16:06 ` Christian Marangi
2024-10-22 21:17 ` Rob Herring
2024-10-22 21:32 ` Benjamin Larsson
2024-10-22 16:57 ` Benjamin Larsson
2024-10-22 20:02 ` Benjamin Larsson
2024-10-22 21:08 ` Rob Herring
2024-10-22 21:12 ` Christian Marangi [this message]
2024-10-22 21:21 ` Benjamin Larsson
2024-10-18 13:19 ` [PATCH v8 4/6] dt-bindings: mfd: Add support for Airoha EN7581 GPIO System Controller Lorenzo Bianconi
2024-10-18 13:19 ` [PATCH v8 5/6] pinctrl: airoha: Add support for EN7581 SoC Lorenzo Bianconi
2024-10-18 13:19 ` [PATCH v8 6/6] pwm: " Lorenzo Bianconi
2024-10-21 13:42 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6718152c.050a0220.3afab9.2d2b@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benjamin.larsson@genexis.eu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=sean.wang@kernel.org \
--cc=ukleinek@kernel.org \
--cc=upstream@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).