Re: [PATCH 5/5] arm64: dts: mediatek: mt8516: add keypad node

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 04/12/24 20:05, Val Packett ha scritto:
> Add a keypad matrix node for the MT8516/MT8167 SoC.
> 
> Signed-off-by: Val Packett <val@packett.cool>
> ---
>   arch/arm64/boot/dts/mediatek/mt8516.dtsi | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> index e30623ebac0e..3beb9f74ec79 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
> @@ -220,6 +220,16 @@ timer: timer@10008000 {
>   			clock-names = "clk13m", "bus";
>   		};
>   
> +		keypad: keypad@10002000 {
> +			compatible = "mediatek,mt6779-keypad";

Noupe, you have to add your SoC to the compatible list... both here and in the
binding for mediatek.mt6779-keypad.yaml

compatible = "mediatek,mt8516-keypad", "mediatek,mt6779-keypad"

for the binding, it's just a simple addition to an enum, nothing else.

Cheers,
Angelo

> +			reg = <0 0x10002000 0 0x1000>;
> +			wakeup-source;
> +			interrupts = <GIC_SPI 149 IRQ_TYPE_EDGE_FALLING>;
> +			clocks = <&clk26m>;
> +			clock-names = "kpd";
> +			status = "disabled";
> +		};
> +
>   		syscfg_pctl: syscfg-pctl@10005000 {
>   			compatible = "syscon";
>   			reg = <0 0x10005000 0 0x1000>;