From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECBC0CAC58E for ; Sat, 13 Sep 2025 13:04:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Subject:Cc:To:From:Date:Message-ID:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bn5g5etmrQRhW0GOll7653iUOWDP8XBcYnO++0L6iOw=; b=QsM9hqMw1YK8i5VTnyJ20rnteb BJBsbXOfJOifHewZu8PoHmf1aBGuIeAU2MzxjPPFelTzaFPro4vrpsuuBHPOweXv5iWBVi3yBD0u7 EasSdmV9/EFvGu+VCn9yXSjcWId2c/4SBzvxXrtrtJdZq99bwVxvOVrOK0k6RbW+V1NWh7f0rcEP0 Ic4O+6IOhkUu/oiG4DCL9pFpDrR0vhmqraKCRnbdMcZbAxkFOX8Z3KbiVZ8gJVDdDlKsKJzeTcb/W OnMmncgCKxSi+3oooL9tf5TLl56hCGlC2qSA9v9vwXCNYklo6R+AsdpdxQw5T06ejLvMxZUCbGTBv /qvg8sYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uxPvt-0000000Enll-0VDa; Sat, 13 Sep 2025 13:04:49 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uxPvp-0000000EnjP-1QAP for linux-mediatek@lists.infradead.org; Sat, 13 Sep 2025 13:04:47 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-45dec026c78so26505715e9.0 for ; Sat, 13 Sep 2025 06:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757768683; x=1758373483; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Bn5g5etmrQRhW0GOll7653iUOWDP8XBcYnO++0L6iOw=; b=BVaQja1Ur6sloefFbg+gUqDbF6ZKP4a4qm1dUDAMk9aKYIsFtKcC9FSY/9oi1agnU0 nQKZh++GRh+GcX54q/lMdOMOq7PtZ6dssgx2EOqVWa6i+21K/Ne4JB1NubiyiCmwa514 E10Du4tubw9WidkP1mQg5nY+MuArXfNJJeJIR4XirKc2JgEkNKnLhu3uKh410F+eawde DHoYYzKk7j7yX/kzy70KBHGRdHt3BZMDfRL9K5hwz3StXWX+VZQ1/rQu7Z4U5Gy/pvyT 0W99JAW37pVcP9wZZiRqoHxh177gvlI0aKtzqLB43oYNtexqMIItt5K6MF08uO6yMN8j RvPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757768683; x=1758373483; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Bn5g5etmrQRhW0GOll7653iUOWDP8XBcYnO++0L6iOw=; b=Egq35T13YE+CWF+HkC8nC1UFfF0WlnV+wZEexhx2QXNkzQsHfAtuZviAJlJVEu2JSx KpWg0v3Ze0/pLhQa7NppfuOlRn+ads4hBXGJBCWzouBXe+B4YmOFRLrm8kJgZyQkP014 vfj880+iVq/4BcsfoSg+7O1CUJBFMR0fbxij6JGo0zJQIp6oh8NwhicJw59xCTNRZMp7 bqb7IaeF7iyyw/CJorF/5EnPihsO4ZOujPuhUd63H0sE+34DgGWVF8ylXO2VwRKENykG DXOSaOCLUsFvFB1KsKnJP6imrXcJaJAZ/QiVNu2//GP+4CaeLLrzv/Oi/z/PXMN97cVa Psxw== X-Forwarded-Encrypted: i=1; AJvYcCU58iJIpLzL8P0psWZLh0N21rx9F8hEngqzAGgeHEGwI/pV0YTynTQ69FDwNq86edmR4ZffBJjgKiBOMmELfQ==@lists.infradead.org X-Gm-Message-State: AOJu0YzRlCCiJ5jbgBMMsGo1DkZU9JShqgB/aQdH3D3QHkhcoplqWz/b Xh0BPbhDO5afwzq0rfPxyyHtpm24RSOHkDKHZO4fVhhT8h6Vt0MBd1E1 X-Gm-Gg: ASbGncsUohsI3r/BnvDvgaCcWWW7PenEPumNpoqN2yukaFusMms5ZOWejQECK2sUlb3 6IoGc0T8uhMPWTvs+cYLVnmfYo/I7tQcI7fe1T4UUsW6+62UBn7jg9TmAXcDlSH7cuEtU+yEzTV 56UqzPUiDucynHyLBJLjT/8HWqNKMv3CDSrdpk0b/iGZCYe17ErjlcW/AicECkEH24g3iyZRX4U wu4nw7ym68olv5eap9iRuL3IRJMLLgvMsBGbr9jlWCWFwwWMkHSwL13YjBq10MURyVJZFo/Xa3H +IjkljHpnOUDVefLJEOPKVrgzrYr6br1rHwpMbcR69wvhPGzKiPDwHYQi8P4cor7NJyDJwhkhsz L8JXPVjA8rYEeG9jH11x7ivMLBc+5oTYprrR1zrR2pTn0w2VGDsS/Qr0+JF+3/89OVFOXXX001b RWFTQ2 X-Google-Smtp-Source: AGHT+IH7bqCK1wDu540Yv6h59nRCAcKulg0ljt7g6L2IwpwzA60j/nsTl5Zjtr2oKtoo9w4/vWv6Gg== X-Received: by 2002:a05:600c:a45:b0:45d:dd9c:4467 with SMTP id 5b1f17b1804b1-45f211ca33cmr60235475e9.7.1757768682776; Sat, 13 Sep 2025 06:04:42 -0700 (PDT) Received: from Ansuel-XPS. (host-95-249-236-54.retail.telecomitalia.it. [95.249.236.54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45e015784c3sm105911875e9.10.2025.09.13.06.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Sep 2025 06:04:42 -0700 (PDT) Message-ID: <68c56bea.050a0220.a9dbf.b7c8@mx.google.com> X-Google-Original-Message-ID: Date: Sat, 13 Sep 2025 15:04:40 +0200 From: Christian Marangi To: Simon Horman Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Heiner Kallweit , Russell King , "Chester A. Unal" , Daniel Golle , DENG Qingfang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH v17 6/8] mfd: an8855: Add support for Airoha AN8855 Switch MFD References: <20250911133929.30874-1-ansuelsmth@gmail.com> <20250911133929.30874-7-ansuelsmth@gmail.com> <20250913130137.GL224143@horms.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250913130137.GL224143@horms.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250913_060445_396526_F04E4EB5 X-CRM114-Status: GOOD ( 22.14 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sat, Sep 13, 2025 at 02:01:37PM +0100, Simon Horman wrote: > On Thu, Sep 11, 2025 at 03:39:21PM +0200, Christian Marangi wrote: > > Add support for Airoha AN8855 Switch MFD that provide support for a DSA > > switch and a NVMEM provider. > > > > Also make use of the mdio-regmap driver and register a regmap for each > > internal PHY of the switch. > > This is needed to handle the double usage of the PHYs as both PHY and > > Switch accessor. > > > > Signed-off-by: Christian Marangi > > ... > > > diff --git a/drivers/mfd/airoha-an8855.c b/drivers/mfd/airoha-an8855.c > > ... > > > +static int an855_mdio_register(struct device *dev, struct an8855_core_priv *priv) > > +{ > > + struct device_node *mdio_np; > > + int ret; > > + > > + mdio_np = of_get_child_by_name(dev->of_node, "mdio"); > > + if (!mdio_np) > > + return -ENODEV; > > + > > + for_each_available_child_of_node_scoped(mdio_np, phy_np) { > > + ret = an8855_phy_register(dev, priv, phy_np); > > + if (ret) > > + break; > > + } > > Hi Christian, > > Maybe it cannot happen, but if the loop above iterates zero times, > then ret will be used uninitialised below. > > Flagged by Smatch. > Do you have hint of how to run smatch on this? Is there a simple arg to make to enable this? Anyway yes it goes against schema but it's possible somehow to have a very broken DT node with no phy in it. > > + > > + of_node_put(mdio_np); > > + return ret; > > +} > > ... -- Ansuel