Re: [net-next PATCH 2/2] net: airoha: add phylink support for GDM1

Simon Horman
2025-10-22T15:45:53Z

On Tue, Oct 21, 2025 at 09:33:12PM +0200, Christian Marangi wrote:

...

> +static int airoha_setup_phylink(struct net_device *netdev)
> +{
> + struct airoha_gdm_port *port = netdev_priv(netdev);
> + struct device *dev = &netdev->dev;
> + phy_interface_t phy_mode;

Hi Christian,

phy_interface_t is an enum and thus may in practice be unsigned...

> + struct phylink *phylink;
> +
> + phy_mode = device_get_phy_mode(dev);
> + if (phy_mode < 0) {

... if so, this condition will always be false.

I suspect the correct approach here is to change the type of phy_mode to int.

Flagged by Smatch.

> + dev_err(dev, "incorrect phy-mode\n");
> + return phy_mode;
> + }
> +
> + port->phylink_config.dev = dev;
> + port->phylink_config.type = PHYLINK_NETDEV;
> + port->phylink_config.mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE |
> + MAC_10000FD;
> +
> + __set_bit(PHY_INTERFACE_MODE_INTERNAL,
> + port->phylink_config.supported_interfaces);
> +
> + phylink = phylink_create(&port->phylink_config, dev_fwnode(dev),
> + phy_mode, &airoha_phylink_ops);
> + if (IS_ERR(phylink))
> + return PTR_ERR(phylink);
> +
> + port->phylink = phylink;
> +
> + return 0;
> +}
> +
> static int airoha_alloc_gdm_port(struct airoha_eth *eth,
> struct device_node *np, int index)
> {

...

--
pw-bot: cr