From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBD28C4332F for ; Fri, 15 Dec 2023 07:42:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:CC:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2wAqJO6ow5pbhLNgeXDGDdT6gSCu+5ZCYT020dCWPOM=; b=JxrbElsk9ggnsMll3Lb83OOdWx S7THpd8+NeBT4ig+B9a1yy7f+XNWQS8ygNPwqEDO51/I77+MIkUb1YOFCpEEmiGO4W2uKY7YYGJCA ZE6YQK7phSmCNQwG2ZmvRH2dZZrYHKzZSKRB1+QwtbuxgXaYHq4kI2cqB48JNDLVmt4aMpO+WdZuy /6BqROzopYA+2PNvw14wlgcN+AprvXIwKd0Lq6BG9yJO+aQjcxxs+Bt9nAW1c7ZH6GkMW7YPBxByK 8FHuUb47/0P9iYyTH0CR9jLP4yrgU9VGmySPCl79yssi9kPFU/nZgIvGIQ6q241u9eZ/gBSak+NQe uVBSVB9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rE2q1-002KnK-1u; Fri, 15 Dec 2023 07:42:25 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rE2px-002KlB-29; Fri, 15 Dec 2023 07:42:23 +0000 X-UUID: 778b9a8c9b1d11ee9b09ad09c76753c8-20231215 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:CC:To:From:Subject:MIME-Version:Date:Message-ID; bh=2wAqJO6ow5pbhLNgeXDGDdT6gSCu+5ZCYT020dCWPOM=; b=E1IqYSR/4K/sjc1swu8RYVPjxo6eBcVRUShSdKJi5tlB5Cooayf22p9PJn/cGjfBmJ/zPCapa+FPNkYqfnHSLgqPCGolodPU8gBH+GG4XGy/PZihUe/x5YsVY+WM+fynCiZqXV6nV0wVofBuHJtzocrLmvqLaLqvR7w9XJA4QdU=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.35,REQID:f6a605fb-647a-4874-bed7-3e468f08ea7c,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:5d391d7,CLOUDID:b41236bd-2ac7-4da2-9f94-677a477649d9,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_ULS,TF_CID_SPAM_SNR X-UUID: 778b9a8c9b1d11ee9b09ad09c76753c8-20231215 Received: from mtkmbs14n1.mediatek.inc [(172.21.101.75)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 2139926486; Fri, 15 Dec 2023 00:42:15 -0700 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 15 Dec 2023 15:42:11 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 15 Dec 2023 15:42:09 +0800 Message-ID: <6a0bc9c2-a9c6-5842-b66a-f9f020bf3aa3@mediatek.com> Date: Fri, 15 Dec 2023 15:42:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] arm64: mediatek: remove broken pmic interrupt property Content-Language: en-US From: Macpaul Lin To: AngeloGioacchino Del Regno , "Arnd Bergmann" , , Matthias Brugger , Ben Lok CC: Arnd Bergmann , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , , , , , , , References: <20231212214737.230115-1-arnd@kernel.org> <1ce43346-3f60-b614-cdcc-7d9db8dec758@mediatek.com> In-Reply-To: <1ce43346-3f60-b614-cdcc-7d9db8dec758@mediatek.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--17.802600-8.000000 X-TMASE-MatchedRID: eVEkOcJu0F4OwH4pD14DsPHkpkyUphL9Wot5Z16+u77Bs8kDsMW7wymC jjsTccFFUYtkiBoupX8uAovee89QpC1Wsi+5O6Jc6ivQ8oO6nUIxXH/dlhvLv4KwF4K/wIz9x62 K9vpeVDElpVclvjJJDAdoZ0oEtSg00YEzPS5rM625kfgtJfb41UMYMp0ANFh5jU67CM+uPQRDvi ZnrU/ym8l1PwlhNC8gii+rjsN9t6AdWKRD1iYss521GZGE81yGIR1rLBJm/M54TmuAv2jjeS2Yu hoO5axHdFVDrCqWLfIQbi0n2beMrBElELPcdUQnkX71Hy/ufOYwCmrLlx+SdWjliw+xvItd+876 KLWQRT2+uHCFBcDhnx2NwlAFp+i1v1l2Uvx6idpWdFebWIc3VsRB0bsfrpPIfiAqrjYtFiS/RvL zr5xet56fdmHAkNDU7melNaZ+qBmhqzYP1yklcn7cGd19dSFd X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--17.802600-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: 026B01DCDDCE9116B9D54BB5E5B875CC4A12E046A3197EEE1A7B5B1A873AD7872000:8 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231214_234221_714095_90021D65 X-CRM114-Status: GOOD ( 24.96 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 12/15/23 01:54, Macpaul Lin wrote: > On 12/13/23 19:09, AngeloGioacchino Del Regno wrote: > >> Il 12/12/23 22:47, Arnd Bergmann ha scritto: >>> From: Arnd Bergmann >>> >>> The pmic is connected to the GIC, which uses four-cell interrupt >>> properties, >>> but its interrupt is specified as two-cell that would only make >>> sense for >>> the GPIO irqchip: >>> >>> arch/arm64/boot/dts/mediatek/mt8195.dtsi:464.4-27: Warning >>> (interrupts_property): /soc/i2c@11d01000/pmic@34:#interrupt-cells: >>> size is (8), expected multiple of 16 >>> >>> Remove the interrupt for now to shut up the warning. When someone >>> figures out >>> what the correct interrupt and parent are, we can add it back. >>> >> >> Please, can anyone from MediaTek comment on that? > > Sorry for late response, I've just stuck in other tasks and didn't > notice this > > patch is for genio-1200-evk. I've tested 6.7-rc1 but I thought it > might be an issue > > in origin mt8195.dtsi and not be related to board dts. > >> I see a mt6360_pins on PIO: >>             pinmux = , >>                  ; >> >> ...and that's GPIO128, which may effectively be the IRQ pin for MT6360. >> >> Still, I'm not sure whether the interrupt is on GIC or PIO, please >> clarify, >> otherwise we will have to get this commit upstream. >> > I think it could be solved by adding > > 'interrupt-parent = <&pio>;' to mt6360 node. > > But currently I have no much time to verify it. > > I'll try to find some time to find out the solution tomorrow. > >> Thanks, >> Angelo >> >>> Fixes: f2b543a191b6 ("arm64: dts: mediatek: add device-tree for >>> Genio 1200 EVK board") >>> Signed-off-by: Arnd Bergmann >>> --- >>>   arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts | 2 -- >>>   1 file changed, 2 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts >>> b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts >>> index 70b465f7c6a7..a409ef998746 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts >>> +++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk.dts >>> @@ -238,8 +238,6 @@ &i2c6 { >>>       mt6360: pmic@34 { >>>           compatible = "mediatek,mt6360"; >>>           reg = <0x34>; >>> -        interrupts = <128 IRQ_TYPE_EDGE_FALLING>; >>> -        interrupt-names = "IRQB"; >>>           interrupt-controller; >>>           #interrupt-cells = <1>; >>>           pinctrl-0 = <&mt6360_pins>; >> > > Thanks for pointing out the issue! Let's see if it could be solved by > adding 'interrupt-parents'. > > Macpaul Lin I've send a patch to add 'interrupt-parent' for mt6360 and tested with my local kernel-6.7-rc1. Link: https://lore.kernel.org/linux-devicetree/20231215073252.21586-1-macpaul.lin@mediatek.com/ Thanks for Angelo , Arnd, and Chen-yu's reminding. Best regards, Macpaul Lin