From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-mediatek@lists.infradead.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, matthias.bgg@gmail.com, wenst@chromium.org,
hsinyi@chromium.org, nfraprado@collabora.com,
macpaul.lin@mediatek.com, sean.wang@mediatek.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH 04/15] arm64: dts: mediatek: radxa-nio-12l: Add external MT6360 PMIC on I2C6
Date: Tue, 16 Jan 2024 09:16:54 +0100 [thread overview]
Message-ID: <6a1d612a-200e-4868-8577-49de933cf2bb@linaro.org> (raw)
In-Reply-To: <20240112094632.66310-5-angelogioacchino.delregno@collabora.com>
On 12/01/2024 10:46, AngeloGioacchino Del Regno wrote:
> In preparation for adding the power tree for this board, add a node for
> the MT6360 PMIC, connected to I2C6.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Why do you add new device in pieces? Logical change is "new device", not
"half of device". If the patch is too big, sure, split it into two
chunks, but not 15!
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-16 8:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 9:46 [PATCH 00/15] MediaTek: Introduce MT8395 Radxa NIO 12L devicetree AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 01/15] dt-bindings: arm64: mediatek: Add MT8395 Radxa NIO 12L board compatible AngeloGioacchino Del Regno
2024-01-12 17:06 ` Conor Dooley
2024-01-12 9:46 ` [PATCH 02/15] arm64: dts: mediatek: Introduce the MT8395 Radxa NIO 12L board AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 03/15] arm64: dts: mediatek: radxa-nio-12l: Enable I2C 2/4/6 busses AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 04/15] arm64: dts: mediatek: radxa-nio-12l: Add external MT6360 PMIC on I2C6 AngeloGioacchino Del Regno
2024-01-16 8:16 ` Krzysztof Kozlowski [this message]
2024-01-22 7:28 ` Matthias Brugger
2024-01-12 9:46 ` [PATCH 05/15] arm64: dts: mediatek: radxa-nio-12l: Configure board regulators AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 06/15] arm64: dts: mediatek: radxa-nio-12l: Add Ethernet controller and Xceiver AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 07/15] arm64: dts: mediatek: radxa-nio-12l: Add MT6360 battery charger AngeloGioacchino Del Regno
2024-01-16 8:17 ` Krzysztof Kozlowski
2024-01-12 9:46 ` [PATCH 08/15] arm64: dts: mediatek: radxa-nio-12l: Add support for eMMC and MicroSD AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 09/15] arm64: dts: mediatek: radxa-nio-12l: Enable System Companion Processor AngeloGioacchino Del Regno
2024-01-16 8:18 ` Krzysztof Kozlowski
2024-01-16 8:41 ` AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 10/15] arm64: dts: mediatek: radxa-nio-12l: Enable PCI-Express 0 for USB HUB AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 11/15] arm64: dts: mediatek: radxa-nio-12l: Enable the USB XHCI controllers AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 12/15] arm64: dts: mediatek: radxa-nio-12l: Enable PCI-Express 1 for WiFi AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 13/15] arm64: dts: mediatek: radxa-nio-12l: Enable SPI1/2 for 40pin header AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 14/15] arm64: dts: mediatek: radxa-nio-12l: Enable UART1 " AngeloGioacchino Del Regno
2024-01-12 9:46 ` [PATCH 15/15] arm64: dts: mediatek: radxa-nio-12l: Enable Panfrost for Mali GPU AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a1d612a-200e-4868-8577-49de933cf2bb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@chromium.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox