From: Felix Fietkau <nbd@nbd.name>
To: sean.wang@mediatek.com, lorenzo.bianconi@redhat.com
Cc: Soul.Huang@mediatek.com, YN.Chen@mediatek.com,
Leon.Yen@mediatek.com, Eric-SY.Chang@mediatek.com,
Deren.Wu@mediatek.com, km.lin@mediatek.com,
robin.chiu@mediatek.com, ch.yeh@mediatek.com,
posh.sun@mediatek.com, Eric.Liang@mediatek.com,
Stella.Chang@mediatek.com, jemele@google.com,
yenlinlai@google.com, linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 1/3] mt76: connac: add mt76_connac_mcu_update_sta_cmd support
Date: Wed, 2 Jun 2021 07:59:40 +0200 [thread overview]
Message-ID: <6ddea8d1-551d-5a58-267c-506d22cc932f@nbd.name> (raw)
In-Reply-To: <db74f1c3acd2a2729066810ad72b656681a30693.1622610746.git.objelf@gmail.com>
On 2021-06-02 07:24, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> Add mt76_connac_mcu_update_sta_cmd support that is the prerequisite patch
> for we are able to update the station record with the current state the
> station has into the offload firmware at runtime.
>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
> v1->v2: no change
> ---
> .../net/wireless/mediatek/mt76/mt7615/mcu.c | 6 ++--
> .../wireless/mediatek/mt76/mt76_connac_mcu.c | 32 ++++++++++++++-----
> .../wireless/mediatek/mt76/mt76_connac_mcu.h | 16 ++++++++--
> .../net/wireless/mediatek/mt76/mt7921/main.c | 8 +++--
> .../net/wireless/mediatek/mt76/mt7921/mcu.c | 3 +-
> .../wireless/mediatek/mt76/mt7921/mt7921.h | 2 +-
> 6 files changed, 50 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> index d64b8058b744..6666507f43ed 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h
> @@ -902,6 +902,14 @@ struct mt76_connac_suspend_tlv {
> u8 pad[5];
> } __packed;
>
> + /* 0: state 1 - unauthenticated & unassociated
> + * 1: state 2 - authenticated & unassociated
> + * 2: state 3 - authenticated & associated
> + */
> +#define MT76_STA_INFO_STATE_1 0
> +#define MT76_STA_INFO_STATE_2 1
> +#define MT76_STA_INFO_STATE_3 2
Please turn this into an enum:
enum mt76_sta_info_state {
MT76_STA_INFO_STATE_NONE,
MT76_STA_INFO_STATE_AUTH,
MT76_STA_INFO_STATE_ASSOC
};
The _1 _2 _3 suffixes are not that readable and add extra confusion by
not matching the numeric values.
- Felix
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-06-02 6:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 5:24 [PATCH v2 1/3] mt76: connac: add mt76_connac_mcu_update_sta_cmd support sean.wang
2021-06-02 5:24 ` [PATCH v2 2/3] mt76: mt7921: add mt7921_mcu_sta_update support sean.wang
2021-06-02 8:00 ` Lorenzo Bianconi
2021-06-02 5:24 ` [PATCH v2 3/3] mt76: mt7921: fix sta_state incorrect implementation sean.wang
2021-06-02 7:51 ` Lorenzo Bianconi
2021-06-02 5:59 ` Felix Fietkau [this message]
2021-06-02 7:43 ` [PATCH v2 1/3] mt76: connac: add mt76_connac_mcu_update_sta_cmd support Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ddea8d1-551d-5a58-267c-506d22cc932f@nbd.name \
--to=nbd@nbd.name \
--cc=Deren.Wu@mediatek.com \
--cc=Eric-SY.Chang@mediatek.com \
--cc=Eric.Liang@mediatek.com \
--cc=Leon.Yen@mediatek.com \
--cc=Soul.Huang@mediatek.com \
--cc=Stella.Chang@mediatek.com \
--cc=YN.Chen@mediatek.com \
--cc=ch.yeh@mediatek.com \
--cc=jemele@google.com \
--cc=km.lin@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=posh.sun@mediatek.com \
--cc=robin.chiu@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=yenlinlai@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox