From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59ACDC636CC for ; Tue, 31 Jan 2023 13:26:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TfZfyT/Vvj+XVZkKWfK1JVlF+kIO3JnmZX9PXK0es3k=; b=LNRzRfOiQsxEs0HxDmRpA4T16R d9hg4NLMWCdFa7AHnfZ1xMwBAAgwIEzGOFxPXvypwxrzlYEZVLwSZNVxVsmKHUjFzitwHSOw/2GEG h6s5LQNbr/J+VoWM1X6nReH93rcK3iq2pudj9Rt2QfGFWG2Y8eOlQTWaUDqjpmeojE+QVAG2i2PeX 0v5Qw6usCIlx1r7anuQh27YEmCcbpvS/n/eEWS1PVPIRQdzoUd8MFKfdfKVWA5vwnqlvH/QWXMosz 0h/Kt6P/wz8dkW0xtMcz90GIWE9h528m46j4milCUFCjL1GSoF9TBwkrefREPxDZVIYIN4A0GQL8x 5DGuhsDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMqeC-0085Yf-1P; Tue, 31 Jan 2023 13:26:04 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMqd3-00853G-Co; Tue, 31 Jan 2023 13:24:54 +0000 Received: by mail-wm1-x333.google.com with SMTP id n28-20020a05600c3b9c00b003ddca7a2bcbso591448wms.3; Tue, 31 Jan 2023 05:24:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TfZfyT/Vvj+XVZkKWfK1JVlF+kIO3JnmZX9PXK0es3k=; b=YyzFmDzZYXunsXWpS+omE61fG+I6kwtrGZcleEGZjyd+s6DFwgv71lCGpJiqxrz7zC 4TLlZGft167i58+Bt5gDYp6LnQE6d9iBpyPUxdx7D0jRUlzervAz9045RtJJLjjkP7G+ h9cTDcoaiJ5mTCvg2ryGVIU7ID42L0En/eRnTQRdXyF5XQhZpVml1hdwDylNn4w4QNAw +d92gCbkBnr3BQl2Eut9JhfSxsDgekSn+AHU4Wq3JBF2bFWPShApmA6ZoJaLmaLs/0Su 7dY0JuEDZvwVuJM9DwOWRc7rnc8SeY2yFQYWSflYRBi+pZgPiHo/Z6bb7XusKomPNyM2 Nj5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TfZfyT/Vvj+XVZkKWfK1JVlF+kIO3JnmZX9PXK0es3k=; b=ULlDx088/J7Mk350cA6Pv8H6f2MQ6RVSvFl1NPD0tnVlDkg57vU61tqHrPgKTfb/ld zn5C0uwPpqzUzYGGhXbTrn3eYab8zLCcMxAhcYna2it4ePt0qGugoEGKW4yf1Ayqfqi3 1WsqOTZvDJjU3eJO+WDInLxiUAGU47+qvqQXVfXZ1loz9x4fHwy3fVg6ZAJUDA/DLP+T QirpGbvXv/cy/ZIJuX9Lkg7nzYhGTk4h5xVXcAA7qTokg999rpySCsDcRnikSvN2ATvI PInbCxijBkF7RgBT7BZNfAXFcfWdVgLBMxliSsKhFunclWO1XROaEfAZTuYSWb2JROg8 bFTw== X-Gm-Message-State: AO0yUKXabo0Y3wjdel7w23M/wXic39mVLje6rvB3oLHZEc3jd4RIlWBB zt7wGNcGJAb/ORSa4RLr7qM= X-Google-Smtp-Source: AK7set8VL7QkCMInXUnEBkwTl1JaZ0iii2TwwlogkxDEyM9c8pDA647tjls+yCjV36AYJJkRGVPCQQ== X-Received: by 2002:a05:600c:19d1:b0:3dc:1dc3:7a05 with SMTP id u17-20020a05600c19d100b003dc1dc37a05mr23396109wmq.10.1675171491939; Tue, 31 Jan 2023 05:24:51 -0800 (PST) Received: from [192.168.2.177] ([207.188.167.132]) by smtp.gmail.com with ESMTPSA id e5-20020a05600c254500b003dc47fb33dasm11446087wma.18.2023.01.31.05.24.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 05:24:51 -0800 (PST) Message-ID: <6de52a34-2e59-4a9c-5c7f-b374676be987@gmail.com> Date: Tue, 31 Jan 2023 14:24:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v4 09/14] soc: mediatek: mtk-svs: improve readability of platform_probe Content-Language: en-US To: Roger Lu , Enric Balletbo Serra , Kevin Hilman , Nicolas Boichat Cc: Fan Chen , Jia-wei Chang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20230111074528.29354-1-roger.lu@mediatek.com> <20230111074528.29354-10-roger.lu@mediatek.com> From: Matthias Brugger In-Reply-To: <20230111074528.29354-10-roger.lu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230131_052453_477373_8BDAA7C6 X-CRM114-Status: GOOD ( 16.13 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 11/01/2023 08:45, Roger Lu wrote: > From: Matthias Brugger > > If a compatible misses a match data entry, then something is wrong in > the development phase, we don't need to check for that at runtime. > > Signed-off-by: Matthias Brugger > Reviewed-by: AngeloGioacchino Del Regno > Signed-off-by: Roger Lu Applied, thanks! > --- > drivers/soc/mediatek/mtk-svs.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c > index 41c0ac5ed8d3..354582825082 100644 > --- a/drivers/soc/mediatek/mtk-svs.c > +++ b/drivers/soc/mediatek/mtk-svs.c > @@ -2394,10 +2394,6 @@ static struct svs_platform *svs_platform_probe(struct platform_device *pdev) > int ret; > > svsp_data = of_device_get_match_data(&pdev->dev); > - if (!svsp_data) { > - dev_err(&pdev->dev, "no svs platform data?\n"); > - return ERR_PTR(-EPERM); > - } > > svsp = devm_kzalloc(&pdev->dev, sizeof(*svsp), GFP_KERNEL); > if (!svsp)