From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 678DECD1292 for ; Thu, 11 Apr 2024 07:39:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YMY5paG9O6K9fYS6c+ORmBz53sEPDlRwCr/FodP5P9g=; b=c9qRhf5YJS4BlXo5psK2QmiOEY D3Pv8W2/2Vy0+jrlDSDgAAitelFsxe6YemhQmvM0CAvq4c6OTXzdr7sqndwfHwu+p6Mf/SYxTweNQ P6jcZ0HSj4XB36wVVBPIjLCDKzgfAQKcMw6ZJGkVhRpwKV6UHesiyfZwC7pPDIc3r7PNgz1ZWglXN D1aFVuvqKfnZNxthYeZIyR9MiLIU7vY9m/cqrJm1Y1+sozMo0ZM8eATGyrAdcX19QT7fFw5+NgSGZ YDtdwp9MhEityWC6FvHEyumfW+w9wYYvRkKXIB2rIhATPnMqPH59ANCR/m9tzFbaZ/NKyOMnFHj6o /0Lv99Ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rup1x-0000000AtjN-3Hux; Thu, 11 Apr 2024 07:39:33 +0000 Received: from madrid.collaboradmins.com ([2a00:1098:ed:100::25]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rup1t-0000000AtgL-0jhn; Thu, 11 Apr 2024 07:39:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1712821167; bh=hsuaPyyXe500cwQ9jJuWJ0HPIXunGpuk5Dto5iwuLao=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=zJTpkWsP+ijw64CxiA+6UhA5cy26ShfKAQCEvdPBmas2QwsdDornHYdz8tvpl/gRg au2FO2XY3m9/E4q9S+G4VVCldwx8FhIXrgyY7KgXKmsopveF9WJx8x8/jv0YsL/6UO 5Z/EnfcCLkUlFR1rPo5Ho6F7uBVEb22DLhSgFaaRun64GqT6Gq9wR8ChI6gfH364Jm 9N082Zcrci3QA4LM8SUL4fem/WBrGYIRJU2uoOf16jPl5isGYfkon/HHJF7JP6DmU9 SjTPRvzyj8Vtv2k74JlmGsEsJbUdBoctkZVxJabWM40TBHLnuv9BAseVDPZoo1uAJM 7gIjxCzWe55Lw== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 6B4CD3781107; Thu, 11 Apr 2024 07:39:26 +0000 (UTC) Message-ID: <6e8e553b-8c5f-404a-a396-17d8b3440d93@collabora.com> Date: Thu, 11 Apr 2024 09:39:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP From: AngeloGioacchino Del Regno To: "olivia.wen" , Bjorn Andersson , Mathieu Poirier , Rob Herring Cc: Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Tinghan Shen , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, jason-ch.chen@mediatek.com, yaya.chang@mediatek.com, teddy.chen@mediatek.com References: <20240411033750.6476-1-olivia.wen@mediatek.com> <20240411033750.6476-2-olivia.wen@mediatek.com> <5cf005b9-d737-4509-a9fb-f0e59465482c@collabora.com> Content-Language: en-US In-Reply-To: <5cf005b9-d737-4509-a9fb-f0e59465482c@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240411_003929_370997_E559E09E X-CRM114-Status: GOOD ( 11.25 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 11/04/24 09:34, AngeloGioacchino Del Regno ha scritto: > Il 11/04/24 05:37, olivia.wen ha scritto: >> Under different applications, the MT8188 SCP can be used as single-core >> or dual-core. >> >> Signed-off-by: olivia.wen >> --- >>   Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 ++- >>   1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml >> b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml >> index 507f98f..7e7b567 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml >> @@ -22,7 +22,7 @@ properties: >>         - mediatek,mt8192-scp >>         - mediatek,mt8195-scp >>         - mediatek,mt8195-scp-dual >> - > > Don't remove the blank line, it's there for readability. > >> +      - mediatek,mt8188-scp-dual Ah, sorry, one more comment. Please, keep the entries ordered by name. 8188 goes before 8195. > > After addressing that comment, > > Reviewed-by: AngeloGioacchino Del Regno > >>     reg: >>       description: >>         Should contain the address ranges for memory regions SRAM, CFG, and, >> @@ -195,6 +195,7 @@ allOf: >>           compatible: >>             enum: >>               - mediatek,mt8195-scp-dual >> +            - mediatek,mt8188-scp-dual same here. >>       then: >>         properties: >>           reg: > >