Re: [PATCH v14 3/3] media: platform: mtk-mdp3: add Mediatek MDP3 driver

CK Hu
2022-04-28T04:59:52Z

Hi, Moudy:

On Wed, 2022-04-27 at 15:05 +0800, Moudy Ho wrote:
>

[snip]

> +
> +int mdp_cmdq_send(struct mdp_dev *mdp, struct mdp_cmdq_param *param)
> +{
> + struct mdp_cmdq_cmd cmd;
> + struct mdp_path *path = NULL;
> + struct mdp_cmdq_cb_param *cb_param = NULL;
> + struct mdp_comp *comps = NULL;
> + struct device *dev = &mdp->pdev->dev;
> + int i, ret;
> +
> + atomic_inc(&mdp->job_count);
> +
> + if (atomic_read(&mdp->suspended)) {
> + atomic_dec(&mdp->job_count);
> + return -ECANCELED;
> + }
> +
> + cmd.pkt = cmdq_pkt_create(mdp->cmdq_clt, SZ_16K);
> + if (IS_ERR(cmd.pkt)) {
> + atomic_dec(&mdp->job_count);
> + wake_up(&mdp->callback_wq);
> + return PTR_ERR(cmd.pkt);
> + }
> + cmd.event = &mdp->event[0];
> +
> + path = kzalloc(sizeof(*path), GFP_KERNEL);
> + if (!path) {
> + ret = -ENOMEM;
> + goto err_destroy_pkt;
> + }
> +
> + path->mdp_dev = mdp;
> + path->config = param->config;
> + path->param = param->param;
> + for (i = 0; i < param->param->num_outputs; i++) {
> + path->bounds[i].left = 0;
> + path->bounds[i].top = 0;
> + path->bounds[i].width =
> + param->param->outputs[i].buffer.format.width;
> + path->bounds[i].height =
> + param->param->outputs[i].buffer.format.height;
> + path->composes[i] = param->composes[i] ?
> + param->composes[i] : &path->bounds[i];
> + }
> +
> + ret = mdp_path_ctx_init(mdp, path);
> + if (ret) {
> + dev_err(dev, "mdp_path_ctx_init error\n");
> + goto err_destroy_pkt;
> + }
> +
> + mtk_mutex_prepare(mdp->mdp_mutex[MDP_PIPE_RDMA0]);
> + for (i = 0; i < param->config->num_components; i++)
> + mdp_comp_clock_on(&mdp->pdev->dev, path-
> >comps[i].comp);
> +
> + ret = mdp_path_config(mdp, &cmd, path);
> + if (ret) {
> + dev_err(dev, "mdp_path_config error\n");
> + goto err_destroy_pkt;
> + }
> +
> + cb_param = kzalloc(sizeof(*cb_param), GFP_KERNEL);
> + if (!cb_param) {
> + ret = -ENOMEM;
> + goto err_destroy_pkt;
> + }
> +
> + comps = kcalloc(param->config->num_components, sizeof(*comps),
> + GFP_KERNEL);
> + if (!comps) {
> + ret = -ENOMEM;
> + goto err_destroy_pkt;
> + }
> +
> + for (i = 0; i < param->config->num_components; i++)
> + memcpy(&comps[i], path->comps[i].comp,
> + sizeof(struct mdp_comp));
> + cb_param->mdp = mdp;
> + cb_param->user_cmdq_cb = param->cmdq_cb;
> + cb_param->user_cb_data = param->cb_data;
> + cb_param->pkt = cmd.pkt;
> + cb_param->comps = comps;
> + cb_param->num_comps = param->config->num_components;
> + cb_param->mdp_ctx = param->mdp_ctx;
> +
> + cmdq_pkt_finalize(cmd.pkt);
> + ret = cmdq_pkt_flush_async(cmd.pkt,
> + mdp_handle_cmdq_callback,
> + (void *)cb_param);

Matthias has applied patch [1], so I think you have better to base on
patch [1] to send patch.

[1]
https://git.kernel.org/pub/scm/linux/kernel/git/matthias.bgg/linux.git/commit/?h=v5.18-next/soc&id=5252c1c5a08e583ab1363f809002cd8a59272b35

Regards,
CK

> + if (ret) {
> + dev_err(dev, "cmdq_pkt_flush_async fail!\n");
> + goto err_clock_off;
> + }
> + kfree(path);
> + return 0;
> +
> +err_clock_off:
> + mtk_mutex_unprepare(mdp->mdp_mutex[MDP_PIPE_RDMA0]);
> + mdp_comp_clocks_off(&mdp->pdev->dev, cb_param->comps,
> + cb_param->num_comps);
> +err_destroy_pkt:
> + cmdq_pkt_destroy(cmd.pkt);
> + atomic_dec(&mdp->job_count);
> + wake_up(&mdp->callback_wq);
> + kfree(comps);
> + kfree(cb_param);
> + kfree(path);
> +
> + return ret;
> +}