From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68ACFC46467 for ; Tue, 10 Jan 2023 08:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wawoO53rvJlk1mkrEk3Mn7XLvK6KEeT6tqX3/48e1U8=; b=3s3E+o+5LLaz8Ebmh8RTeP/evU mmGo7BY4SYg5fziLKQk6nXFR2kcckrezxb3DXp28XigdW6pOAo+wZ8SYTu4/BvcsZm1SGUJyoJ6EQ hjGz5ZFbBZe6nTob8fJU9COTxGAuYJJOq/kE2fxBWJega3UOX2CEwt94fvlLOljf0qBWMm22i/zzy hEDYrhpp+RmC2pJWx+Ig/KFzCLjULJGP1Uchn9JEciphRcA9R4Ocu0P7eVRzbRKh5Db9vMNIw6Gk/ x0nmb4F0AVbZKTW98ecSsMbeuo1m0wbliuL5vysx2AxvnZGiqY1bpo967+26TtYJ2lbch/9lIGrtb 4s+yQqAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pF9yK-005nfy-8Z; Tue, 10 Jan 2023 08:27:04 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pF9y9-005nbT-Bh for linux-mediatek@lists.infradead.org; Tue, 10 Jan 2023 08:26:54 +0000 Received: by mail-wm1-x32d.google.com with SMTP id k22-20020a05600c1c9600b003d1ee3a6289so9196972wms.2 for ; Tue, 10 Jan 2023 00:26:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=wawoO53rvJlk1mkrEk3Mn7XLvK6KEeT6tqX3/48e1U8=; b=Pr9agmqsqknAJz4q08X2fSpPXl8kZ8Z5uKdN4Vv71jNwgsf/nNe86VXEyygxPjlS1+ gh/phTG0PdLsHhZdshqlb5kYaQvTDXCXFwOhBsnXxIcWteCMcYoy5Qfs3SsrxkWLLx3W hugOFc5Hcu3lEo7HJkKfdm+xi9R4ToC5ofhUwt8yR7aTMtheBUy8nXzk+YeSc4/MIGmj iD/UurKfMlWmDuUgf0tfMLblapSoqUpYumCISSHxfU0vA0+iib6EPvbgXmkBVX5aLl6K b+wkefGVbEhaGjydfCcfx2NBpZjUVLA14rAOF6IeuLZdbqp88gk3Nlm2m5/UhHvPAel0 I72Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wawoO53rvJlk1mkrEk3Mn7XLvK6KEeT6tqX3/48e1U8=; b=RY9EfZ3F/O+8W76Zw7KZF3D5e/tVa0hbXv6m1vs85nI5fIXgCXnhMew3MBqkyGiLv4 6uDqyCpQ9rU6EJI2pzRpFwLameiBikfPlK5vNBF+i+mP0RKNpNDosRXGdWt2F3rg1Rvx E9S/RozGAoAmPv1fFuFUXFh37mTenGfYyYcOkHMx5O9UCVoKfptVMLLJZKmHzHLSx9qI YXxEO2WmMhxyIIO26beqJAYWViLHctjUEFwW9y+kYyHHyphknbHZG/NVP+mdBrqqACHZ u2QeauLvnCK8Aa6PNbAl0DNbGsyl42D4OOREtcda4t+yIbvqzzIP26neLe8TEEPJa27R C6/g== X-Gm-Message-State: AFqh2kr0dAqP/WcgZ9Fm2XhZ06fnEDRDWoeaiH/gc1W44QYXThQ4KUQn +JveRmuHIYSQMIBJSEiqeqlmFg== X-Google-Smtp-Source: AMrXdXt2gDqizNUTxd+mOomuKh6q+bSdCe2n3FEqcVtnbcChDYNm1xQohVp5HnaiBOhdC0GfD1EAIQ== X-Received: by 2002:a05:600c:1d23:b0:3d9:fb59:c16b with SMTP id l35-20020a05600c1d2300b003d9fb59c16bmr190317wms.36.1673339212077; Tue, 10 Jan 2023 00:26:52 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:26cc:e5e1:3044:b226? ([2a01:e0a:982:cbb0:26cc:e5e1:3044:b226]) by smtp.gmail.com with ESMTPSA id v10-20020a05600c444a00b003d998412db6sm19917256wmn.28.2023.01.10.00.26.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 00:26:51 -0800 (PST) Message-ID: <71924012-8955-92f2-5fcc-4632a01bba29@linaro.org> Date: Tue, 10 Jan 2023 09:26:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 From: Neil Armstrong Subject: Re: [PATCH] firmware: meson_sm: stop using 0 as NULL pointer Content-Language: en-US To: Miles Chen , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230110031242.4917-1-miles.chen@mediatek.com> Organization: Linaro Developer Services In-Reply-To: <20230110031242.4917-1-miles.chen@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_002653_406921_F0F904C7 X-CRM114-Status: GOOD ( 14.28 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 10/01/2023 04:12, Miles Chen wrote: > Use NULL for NULL pointer to fix the following sparse warning: > drivers/firmware/meson/meson_sm.c:85:24: sparse: warning: Using plain integer as NULL pointer > > Signed-off-by: Miles Chen > --- > drivers/firmware/meson/meson_sm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/meson_sm.c > index 77aa5c6398aa..3f5ff9ed668e 100644 > --- a/drivers/firmware/meson/meson_sm.c > +++ b/drivers/firmware/meson/meson_sm.c > @@ -82,7 +82,7 @@ static void __iomem *meson_sm_map_shmem(u32 cmd_shmem, unsigned int size) > > sm_phy_base = __meson_sm_call(cmd_shmem, 0, 0, 0, 0, 0); > if (!sm_phy_base) > - return 0; > + return NULL; > > return ioremap_cache(sm_phy_base, size); > } Reviewed-by: Neil Armstrong