From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [v2 00/10] arm/arm64: mediatek: Fix mmsys device probing Date: Tue, 24 Apr 2018 11:46:13 +0200 Message-ID: <723392d5-ee51-d49b-050b-db4f9709e6bf@gmail.com> References: <20180424054854.bpd6h3imazhqnuy3@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180424054854.bpd6h3imazhqnuy3@dell> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Lee Jones , matthias.bgg@kernel.org Cc: ulrich.hecht+renesas@gmail.com, laurent.pinchart@ideasonboard.com, ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, mturquette@baylibre.com, sboyd@codeaurora.org, davem@davemloft.net, gregkh@linuxfoundation.org, mchehab@kernel.org, rdunlap@infradead.org, pi-cheng.chen@linaro.org, sean.wang@mediatek.com, linux-clk@vger.kernel.org, linux@armlinux.org.uk, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Matthias Brugger List-Id: linux-mediatek@lists.infradead.org Hi Lee, On 04/24/2018 07:48 AM, Lee Jones wrote: > On Mon, 23 Apr 2018, matthias.bgg@kernel.org wrote: > >> From: Matthias Brugger >> >> Changes since v1: >> - add binding documentation >> - ddp: use regmap_update_bits >> - ddp: ignore EPROBE_DEFER on clock probing >> - mfd: delete mmsys_private >> - add Reviewed-by and Acked-by tags > > I'm confused by the double submission. > > Please can you send it again completely detached from the first and > the second submissions please? > I had some problems with my mailclient. I'll resend as 'v2 resend'. Sorry for that. Matthias >> --- >> >> MMSYS in Mediatek SoCs has some registers to control clock gates (which is >> used in the clk driver) and some registers to set the routing and enable >> the differnet blocks of the display subsystem. >> >> Up to now both drivers, clock and drm are probed with the same device tree >> compatible. But only the first driver get probed, which in effect breaks >> graphics on mt8173 and mt2701. >> >> This patch set introduces a new mfd device, which binds against the mmsys >> compatible and takes care of probing the needed devices. It was tested on the >> bananapi-r2 and the Acer R13 Chromebook. >> >> >> Matthias Brugger (10): >> dt-bindings: mediatek: mmsys: Add support for mfd >> drm/mediatek: Use regmap for register access >> mfd: mtk-mmsys: Add mmsys driver >> drm/mediatek: mt2701: switch to mfd probing. >> clk: mediatek: mt2701-mm: switch to mfd device >> mfd: mtk-mmsys: Add mt8173 nodes >> drm/mediatek: Add mfd support for mt8173 >> clk: mediatek: mt8173-mm: switch to mfd device >> drm: mediatek: Omit warning on probe defers >> MAINTAINERS: update Mediatek Soc entry >> >> .../bindings/arm/mediatek/mediatek,mmsys.txt | 2 - >> .../bindings/display/mediatek/mediatek,disp.txt | 2 +- >> .../devicetree/bindings/mfd/mediatek,mmsys.txt | 27 +++++++ >> MAINTAINERS | 2 + >> drivers/clk/mediatek/clk-mt2701-mm.c | 10 +-- >> drivers/clk/mediatek/clk-mt8173.c | 17 +++- >> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +- >> drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 41 ++++------ >> drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 4 +- >> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 33 ++++---- >> drivers/gpu/drm/mediatek/mtk_drm_drv.h | 2 +- >> drivers/mfd/Kconfig | 9 +++ >> drivers/mfd/Makefile | 2 + >> drivers/mfd/mtk-mmsys.c | 93 ++++++++++++++++++++++ >> 14 files changed, 189 insertions(+), 59 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mmsys.txt >> create mode 100644 drivers/mfd/mtk-mmsys.c >> >