From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19A9DC77B6E for ; Fri, 14 Apr 2023 08:52:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ftuw3UMilu8l2b5dRswcK+6i7A7X4UnxqGe15PT1fxE=; b=sjq4+gNnU+7d0VJXJK7CFXACbG 1RHbGn3SA3piRDD17Vfs7nIEskImudJ6NFrYSWy8/OnF4naKXld6X/g2sGxmQeMuyXxVxvJbUmStd o/unIfD1EGy4Me5DsqOYK5/ab9WwhBD8nPZpxCQVmYeMRu8hka7xjlw/Xc4OCWTFdq19B+KjoFM3g P9Gsxfsk7RVdDoqR4xGytJWdccxpAOxDrAfDFTktSwLpDWjXPjwThZNPatmLSqtZEq/7rDsqJ1doe gwEppppZ2h2iZfri8HmKxRxcK2jDdWRNbFQpPcbo1njnBaJdlxvrI7ACNO1e65VXvYOvCd+i8I6w5 i9O9czdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pnFA5-008nMk-12; Fri, 14 Apr 2023 08:52:05 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pnFA2-008nLi-1Z for linux-mediatek@lists.infradead.org; Fri, 14 Apr 2023 08:52:04 +0000 Received: by mail-ej1-x62b.google.com with SMTP id c9so5007050ejz.1 for ; Fri, 14 Apr 2023 01:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681462321; x=1684054321; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ftuw3UMilu8l2b5dRswcK+6i7A7X4UnxqGe15PT1fxE=; b=T52l6eQLvfn2sr/g3hmgUKtS5XsQv8MDNpk0D5Aou7STdMVuIFWxuR/M6OENureCtE fY2UcWDkb6mzBiX7xvw5Eo63dENC+invb044pfJxP9Pucg+XuSo22M54Jayq0Y6uZPee kWaIQHHFoS3BfYv7JPmAIJfbfdy4TuFsOO+aW8HUStOgqdtPAtSCHfhcfmxuyS4VSISN OTWzhYKSGqMHbQqHv9Y+pJpNrYvb3ZFgcwj1FmkRi5iMDw4YnwD7rtzNaX3evvATTlS+ vNsV4eU/FLo+o15n3AQ5AtZdKsg5GPRjx0mZX7F90Eqg/Vp6UXioXM8TbKOyIjOQsp4y YjHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681462321; x=1684054321; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ftuw3UMilu8l2b5dRswcK+6i7A7X4UnxqGe15PT1fxE=; b=ZglBdQyOcJE1GyBplkf4i6mR4fzy/xrUIuMgPa9ZBMN6BVHso6xQRKsVX8+o0ADFAr RMwcveZ3a4+YefiwDjwX3oW1Z9l1cSYLf0ZWYfAXh1s15J/P02d41oxqxwkaLvDgYcy1 EtCmw46S/NH4+QEelimY3/hpxL6+GYGlQm/N7iQay3b7yF45iHhKUdy2IfX0n4nbQZ4L UDN9GH6Fn8aFZce4baEFxd3E3TZRWeAgHKYL7LmbQ0aQvpRbyNGaMznXuUhBvlOiXyEU 7LLs6fP4mu6FXlYkc/wvy71J+hbt10QE+ZignzD8UNB+jXUk6sOBnCVGMG/pzIBYUyQF pukw== X-Gm-Message-State: AAQBX9d0AGeQ6NRexf7XgB82KQeM9In/3NkyBja87QVz2Ga9xYSEmXYM KdKlCLumdM86b69t7id4DKr/sg== X-Google-Smtp-Source: AKy350ZGMQqG6EaGl3Xlc4WmAQP09GFYq2Qn4E1EDRefqvbMGtKVMeeI2wcHlp3lEbsd7lTJ4PjXmw== X-Received: by 2002:a17:907:8b98:b0:870:d9a:9ebb with SMTP id tb24-20020a1709078b9800b008700d9a9ebbmr5778987ejc.38.1681462320945; Fri, 14 Apr 2023 01:52:00 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:8a60:6b0f:105a:eefb? ([2a02:810d:15c0:828:8a60:6b0f:105a:eefb]) by smtp.gmail.com with ESMTPSA id m9-20020a1709062b8900b0094a9b9c4979sm2162123ejg.88.2023.04.14.01.51.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 01:52:00 -0700 (PDT) Message-ID: <7256414b-5553-e025-334f-b8df48f40c31@linaro.org> Date: Fri, 14 Apr 2023 10:51:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v1 3/6] soc: mediatek: virt: geniezone: Introduce GenieZone hypervisor support Content-Language: en-US To: =?UTF-8?B?WWktRGUgV3UgKOWQs+S4gOW+tyk=?= , "corbet@lwn.net" , "robh+dt@kernel.org" , "catalin.marinas@arm.com" , "krzysztof.kozlowski+dt@linaro.org" , =?UTF-8?B?WWluZ3NoaXVhbiBQYW4gKOa9mOepjui7kik=?= , "matthias.bgg@gmail.com" , "angelogioacchino.delregno@collabora.com" , "will@kernel.org" , Trilok Soni Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?UTF-8?B?TVkgQ2h1YW5nICjojormmI7ouo0p?= , "devicetree@vger.kernel.org" , =?UTF-8?B?UGVpTHVuIFN1ZWkgKOmai+WfueWAqyk=?= , =?UTF-8?B?TGlqdS1jbHIgQ2hlbiAo6Zmz6bqX5aaCKQ==?= , =?UTF-8?B?SmFkZXMgU2hpaCAo5pa95ZCR546oKQ==?= , "linux-arm-kernel@lists.infradead.org" , =?UTF-8?B?U2hhd24gSHNpYW8gKOiVreW/l+elpSk=?= , =?UTF-8?B?TWlsZXMgQ2hlbiAo6Zmz5rCR5qi6KQ==?= , "linux-doc@vger.kernel.org" , =?UTF-8?B?SXZhbiBUc2VuZyAo5pu+5b+X6LuSKQ==?= , =?UTF-8?B?WmUteXUgV2FuZyAo546L5r6k5a6HKQ==?= References: <20230413090735.4182-1-yi-de.wu@mediatek.com> <20230413090735.4182-4-yi-de.wu@mediatek.com> <1aa701cc-92ca-71be-0663-df4bfae66c2f@linaro.org> <5c1d69c8-d973-fa7b-1f14-c72729ff5594@gmail.com> <533a1a9b653cf63f1e5df7f95d1b23902809561d.camel@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <533a1a9b653cf63f1e5df7f95d1b23902809561d.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230414_015202_561808_5A8274E5 X-CRM114-Status: GOOD ( 17.12 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 14/04/2023 10:43, Yi-De Wu (吳一德) wrote: > On Thu, 2023-04-13 at 19:08 +0200, Matthias Brugger wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On 13/04/2023 14:55, Krzysztof Kozlowski wrote: >>> On 13/04/2023 11:07, Yi-De Wu wrote: >>>> From: "Yingshiuan Pan" >>>> >>>> GenieZone is MediaTek proprietary hypervisor solution, and it is >>>> running >>>> in EL2 stand alone as a type-I hypervisor. This patch exports a >>>> set of >>>> ioctl interfaces for userspace VMM (e.g., crosvm) to operate >>>> guest VMs >>>> lifecycle (creation, running, and destroy) on GenieZone. >>>> >>>> Signed-off-by: Yingshiuan Pan >>>> Signed-off-by: Yi-De Wu >>>> --- >>>> arch/arm64/include/uapi/asm/gzvm_arch.h | 79 ++++ >>>> drivers/soc/mediatek/Kconfig | 2 + >>>> drivers/soc/mediatek/Makefile | 1 + >>>> drivers/soc/mediatek/virt/geniezone/Kconfig | 17 + >>> >>> Hypervisor drivers do not go to soc. Stop shoving there everything >>> from >>> your downstream. Find appropriate directory, e.g. maybe >>> drivers/virt. >> >> Acked, what is the reason you want to add this to drivers/soc instead >> of >> drivers/virt? >> >> Regards, >> Matthias >> > Noted. We would take your advice and move it from > drivers/soc/mediatek/virt to /drivers/virt on next version. > > The reason we put it under our soc/ is that the drver is highly > propietary for mediatek's product and for aarch64 only. Maybe it's not > general enough to put in under /drivers/virt. If virt folks reject the driver, because it is highly proprietary, then it is not suitable for soc/mediatek either. Your argument is actually not helping you. It's rather a proof that this driver might not be suitable for Linux kernel at all. > https://android-review.googlesource.com/c/kernel/common/+/2447547/1..2/drivers/virt/geniezone/gzvm.h#b91 I don't see there anything suggesting moving to soc/mediatek. Comment from Trilok (+Cc) suggests that your code is simply not portable. Write code which is portable and properly organized. Best regards, Krzysztof