Re: [PATCH] r8152: stop submitting rx for -EPROTO

From: Oliver Neukum <oneukum@suse.com>
To: Alan Stern <stern@rowland.harvard.edu>,
	Hayes Wang <hayeswang@realtek.com>
Cc: Oliver Neukum <oneukum@suse.com>,
	Jason-ch Chen <jason-ch.chen@mediatek.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Project_Global_Chrome_Upstream_Group@mediatek.com"
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"hsinyi@google.com" <hsinyi@google.com>,
	nic_swsd <nic_swsd@realtek.com>
Subject: Re: [PATCH] r8152: stop submitting rx for -EPROTO
Date: Mon, 4 Oct 2021 13:44:54 +0200	[thread overview]
Message-ID: <72573b91-11d7-55a0-0cd8-5afbc289b38c@suse.com> (raw)
In-Reply-To: <20211001152226.GA505557@rowland.harvard.edu>

On 01.10.21 17:22, Alan Stern wrote:
> On Fri, Oct 01, 2021 at 03:26:48AM +0000, Hayes Wang wrote:
>>> Alan Stern <stern@rowland.harvard.edu>
>>> [...]
>>>> There has been some discussion about this in the past.
>>>>
>>>> In general, -EPROTO is almost always a non-recoverable error.
>>> Excuse me. I am confused about the above description.
>>> I got -EPROTO before, when I debugged another issue.
>>> However, the bulk transfer still worked after I resubmitted
>>> the transfer. I didn't do anything to recover it. That is why
>>> I do resubmission for -EPROTO.
>> I check the Linux driver and the xHCI spec.
>> The driver gets -EPROTO for bulk transfer, when the host
>> returns COMP_USB_TRANSACTION_ERROR.
>> According to the spec of xHCI, USB TRANSACTION ERROR
>> means the host did not receive a valid response from the
>> device (Timeout, CRC, Bad PID, unexpected NYET, etc.).
> That's right.  If the device and cable are working properly, this 
> should never happen.  Or only extremely rarely (for example, caused 
> by external electromagnetic interference).
And the device. I am afraid the condition in your conditional statement
is not as likely to be true as would be desirable for quite a lot setups.
>
>> It seems to be reasonable why resubmission sometimes works.
> Did you ever track down the reason why you got the -EPROTO error 
> while debugging that other issue?  Can you reproduce it?

Is that really the issue though? We are seeing this issue with EPROTO.
But wouldn't we see it with any recoverable error?

AFAICT we are running into a situation without progress because drivers
retry

* forever
* immediately

If we broke any of these conditions the system would proceed and the
hotplug event be eventually be processed. We may ask whether drivers should
retry forever, but I don't see that you can blame it on error codes.

    Regards
        Oliver

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek