From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: Aw: [PATCH 2/2] drm/mediatek: Add Mediatek framebuffer device Date: Fri, 18 Jan 2019 09:39:08 +0100 Message-ID: <74eba84d-4686-698a-6100-d72dabd15a21@gmail.com> References: <20190116013924.11345-1-ck.hu@mediatek.com> <20190116013924.11345-2-ck.hu@mediatek.com> <1547775975.4221.11.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1547775975.4221.11.camel@mtksdaap41> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: CK Hu , Frank Wunderlich Cc: Daniel Vetter , srv_heupstream@mediatek.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, =?UTF-8?Q?Noralf_Tr=ef=bf=bdnnes?= , linux-mediatek@lists.infradead.org, Philipp Zabel , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org On 18/01/2019 02:46, CK Hu wrote: > Hi, Frank: > > On Thu, 2019-01-17 at 15:14 +0100, Frank Wunderlich wrote: >> Hi, >> >> this Patchset does not hang on Bananapi R2, but does not show anything on FB-Console...seems anything is missing >> >> https://github.com/frank-w/BPI-R2-4.14/tree/4.20-fbdev >> >> dmesg | grep 'fb\|framebuffer' >> [ 0.000000] Linux version 4.20.0-rc7-bpi-r2-fbdev (frank@frank-N56VZ) (gcc version 7.3.0 (Ubuntu/Linaro 7.3.0-27ubuntu1~18.04)) 9 >> [ 0.000000] cma: Reserved 64 MiB at 0xfb800000 >> [ 0.000000] Kernel command line: board=bpi-r2 console=earlyprintk console=tty1 fbcon=map:0 console=ttyS0,115200 root=/dev/mmcblk7 >> [ 5.733185] [drm:drm_fb_helper_generic_probe] surface width(1280), height(1024) and bpp(32) >> [ 5.754452] [drm:drm_mode_addfb2] [FB:44] >> [ 5.792878] mediatek-drm 14000000.dispsys: fb0: DRM emulated frame buffer device >> [ 5.814067] [drm:drm_fb_helper_hotplug_event.part.11] >> [ 6.203083] mediatek-drm 14000000.dispsys: [drm:drm_client_dev_hotplug] fbdev: ret=0 >> [ 24.930347] mediatek-drm 14000000.dispsys: [drm:drm_client_dev_restore] fbdev: ret=0 >> [ 25.196872] mediatek-drm 14000000.dispsys: [drm:drm_client_dev_restore] fbdev: ret=0 >> [ 25.281184] [drm:drm_mode_addfb2] [FB:49] >> [ 27.947962] [drm:drm_mode_addfb2] [FB:49] > > The log does not show any information of error, but it close fbdev at > the time 24.930347. > > I just test vmap() by writing white color into framebuffer after vmap() > and use user space program to control fbdev to show this framebuffer and > the panel shows white screen. So I believe that vmap() and fbdev works > fine, but I'm not sure what happen to fbcon. I would try to setup fbcon > to find out the bug. If you could try to debug parallelly, it would be > much help. > may it be the not yet fixed mmsys compatible problem? Frank, did you test with my last series [1]? Regards, Matthias [1] https://patchwork.kernel.org/cover/10686345/ > Regards, > CK > >> >> regards Frank >> >> >>> Gesendet: Mittwoch, 16. Januar 2019 um 02:39 Uhr >>> Von: "CK Hu" >>> An: "Philipp Zabel" , "David Airlie" , "Daniel Vetter" , "Matthias Brugger" , "Noralf Tr�nnes" , "Frank Wunderlich" >>> Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com, "CK Hu" >>> Betreff: [PATCH 2/2] drm/mediatek: Add Mediatek framebuffer device >>> >>> For Mediatek drm driver, use fbdev emulation to create a framebuffer >>> device. >>> >>> Signed-off-by: CK Hu >>> --- >>> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> index 6ec4ca070382..5fcc0e294696 100644 >>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c >>> @@ -16,6 +16,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include >>> #include >>> @@ -378,6 +379,10 @@ static int mtk_drm_bind(struct device *dev) >>> if (ret < 0) >>> goto err_deinit; >>> >>> + ret = drm_fbdev_generic_setup(drm, 32); >>> + if (ret) >>> + DRM_ERROR("Failed to initialize fbdev: %d\n", ret); >>> + >>> return 0; >>> >>> err_deinit: >>> -- >>> 2.18.1 >>> >>> >> >> _______________________________________________ >> Linux-mediatek mailing list >> Linux-mediatek@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-mediatek > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek >