From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Allen Ye <allen.ye@mediatek.com>, <linux-wireless@vger.kernel.org>
Cc: Johannes Berg <johannes.berg@intel.com>,
Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Evelyn Tsai <evelyn.tsai@mediatek.com>,
Money Wang <money.wang@mediatek.com>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2] wifi: mac80211: Update bssid indicator with real BSS numbers
Date: Tue, 23 Apr 2024 12:12:32 -0700 [thread overview]
Message-ID: <7587ecfc-e580-488f-b74e-20e2c115df93@quicinc.com> (raw)
In-Reply-To: <20231208063820.25983-1-allen.ye@mediatek.com>
On 12/7/2023 10:38 PM, Allen Ye wrote:
> The cnt member in mbssid is the count of total number of MBSSID elements
> instead of BSSID. Therefore, we fix this by reading the MaxBSSID Indicator
> field directly.
Commit text is much more readable if you somewhat follow the guidance:
Describe what the current code does.
Describe the problem with the current code.
Describe how to modify the code to fix the problem.
And write this at a high enough level that a manager can understand :)
prev parent reply other threads:[~2024-04-23 19:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 6:38 [PATCH v2] wifi: mac80211: Update bssid indicator with real BSS numbers Allen Ye
2023-12-14 12:29 ` Johannes Berg
2023-12-27 9:38 ` Allen Ye (葉芷勳)
2024-04-23 11:21 ` Johannes Berg
2024-04-23 11:28 ` Johannes Berg
2024-05-02 16:45 ` Aloka Dixit
2024-04-23 19:12 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7587ecfc-e580-488f-b74e-20e2c115df93@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=allen.ye@mediatek.com \
--cc=evelyn.tsai@mediatek.com \
--cc=johannes.berg@intel.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=money.wang@mediatek.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox