From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37C8FECAAA1 for ; Sun, 23 Oct 2022 05:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JAh9SjnhvVDtw00ZQA7GujHx/y75h1Pvq1q0FWnZKi8=; b=vdJ0Won4mfurXYpCW+JzVzlMra IzceNUqU52QsfWTW9xrxkO0Hj0fb+j0wpUaPdcWLOiBRiBhs+8fTljYbsQ39GBD/iUuNCAlSfEefa bDSzGZLVTHYLzf9VZOLoj10JIffnqjsd+cjkY1QqDk/VZRmA6TGCHKHsVNHteCIEJpUcFAUUg8ncv yJhXGy8yjJoyfmudghrciol5+PEuDOuCnfS0qn9TveeodtQ4xquYg62HssmnACiGhj1gJLJQkkDy/ dqU0H83VeGpIs55vAZBKiP5ZhJcj85i8fbk1LFxXZDRWXTR2KlYDJOKUhA3Gh836T1Wdg+7jqcCsi BgbCNSMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1omTar-00ETCL-93; Sun, 23 Oct 2022 05:32:17 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1omTag-00ETAi-IG; Sun, 23 Oct 2022 05:32:08 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 6DA421884623; Sun, 23 Oct 2022 05:32:02 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 5A307250007B; Sun, 23 Oct 2022 05:32:02 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id 46F999EC000A; Sun, 23 Oct 2022 05:32:02 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Sun, 23 Oct 2022 07:32:02 +0200 From: netdev@kapio-technology.com To: Ido Schimmel Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Russell King , Christian Marangi , Daniel Borkmann , Yuwei Wang , Petr Machata , Florent Fourcot , Hans Schultz , Joachim Wiberg , Amit Cohen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v8 net-next 02/12] net: bridge: add blackhole fdb entry flag In-Reply-To: References: <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-3-netdev@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: <7690b7f836b144b60f60b3b68d3bf784@kapio-technology.com> X-Sender: netdev@kapio-technology.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221022_223206_774003_68603210 X-CRM114-Status: UNSURE ( 8.15 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 2022-10-20 15:06, Ido Schimmel wrote: > [...] > >> @@ -1140,7 +1148,7 @@ static int __br_fdb_add(struct ndmsg *ndm, >> struct net_bridge *br, >> err = br_fdb_external_learn_add(br, p, addr, vid, true); >> } else { >> spin_lock_bh(&br->hash_lock); >> - err = fdb_add_entry(br, p, addr, ndm, nlh_flags, vid, nfea_tb); >> + err = fdb_add_entry(br, p, addr, ndm, nlh_flags, vid, ext_flags, >> nfea_tb); > > I believe the preference is to wrap to 80 columns when possible. Very strange... since I ran checkpatch.pl from the net-next kernel itself and it did not give me any warnings about 80 columns, but rather said 'patch is ready for submission'. As this is silent, could it be some missing python plugins or something to do with perl?