From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1C25C77B61 for ; Thu, 13 Apr 2023 11:33:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rHZuyoyi97XMmJJYhlEhjauiT+JK+zjp78LuChTpNkg=; b=nGkEZqErTBu1WySWGrI5uYxmK0 L6qQzHINPE4JHEANLozGdMRRNgtT60+KN6lG/4hNucuUe8AJREWPWzP0yegFWO/MYBvuj7Jkxr0oY voVFKtZ854ZoPGhRX38FXrPfoQnEPSuROrGtWCwBDVPJi8hjFVO1UAU9Osemxg6lhxXZTSdGiav2Z 5jdRY8zwVfTJvk7ZPAzRhzKsJIUtjXMJwmND2ro22yMCQ1G3ilQOba8PqCzMM0pBozaACKoGXWIIn rWC6zXJ69Vg2Z5WFP8zg07p0eAkCgyULloCibBTbyjsc96RuDtn4fQTPuGn0p3rDklA7ZCE6Mu5a9 w4n4Qkqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmvCL-0065JR-36; Thu, 13 Apr 2023 11:33:05 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmvCI-0065IN-2C; Thu, 13 Apr 2023 11:33:03 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 90E2C6603213; Thu, 13 Apr 2023 12:33:00 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1681385581; bh=fne5vl1dtaJc7cfXmmcmLI+T79wzFSh9tR5IvtINcUY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Ck2lwMMNcQmkEzK1WZ9PCnPNBITalhay8LToLlOmiz8aSIhpybVtJy1zOt4JPxMmS 5+XMqV6JQCn6RfvoBbcw9mpBg02Sr2NdmJQ7IpOuezPiAF4zIIZ/jN999SaWm45Kil LxXZbIydwzdjxz9UceXfRre++xcwWVDds2I6xPvEiKU0c5MhK/RWSqGnxGaZlb4tab qXx4fNeqrwfIhMN8h3fKtPDs0b7To1ee7Vo7LxCuoFfV1cN2OqAnT0MK9/aEvt0LFu 1nvFEA8xts/i+5IKNF3xTITa9sN2WyHwpj80KT7+RUOfqL7Ma3yslPyTVi3AO/MHO+ g/a71KyMibHWQ== Message-ID: <76c89ad1-a189-c907-590c-35ae6b7edd9e@collabora.com> Date: Thu, 13 Apr 2023 13:32:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 7/7] leds: leds-mt6323: Add support for WLEDs and MT6332 Content-Language: en-US To: Pavel Machek Cc: lee@kernel.org, sean.wang@mediatek.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20230412153310.241046-1-angelogioacchino.delregno@collabora.com> <20230412153310.241046-8-angelogioacchino.delregno@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230413_043302_846800_B2AE03DB X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 13/04/23 13:06, Pavel Machek ha scritto: > Hi! > >> Add basic code to turn on and off WLEDs and wire up MT6332 support >> to take advantage of it. >> This is a simple approach due to to the aforementioned PMIC supporting >> only on/off status so, at the time of writing, it is impossible for me >> to validate more advanced functionality due to lack of hardware. > > >> @@ -467,14 +590,24 @@ static int mt6323_led_probe(struct platform_device *pdev) >> goto put_child_node; >> } >> >> + is_wled = of_property_read_bool(child, "mediatek,is-wled"); >> + > > This needs documenting in the binding, no? Yes, and I forgot to. Would it be okay if I send a supplementary patch out of this series to document that since the bindings are already acked? Regards, Angelo