Re: [PATCH v2 00/15] arm64: dts: mediatek: Add Openwrt One AP functionality

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 01/11/25 14:32, Sjoerd Simons ha scritto:
> Significant changes in V2:
>    * https://lore.kernel.org/lkml/20251016-openwrt-one-network-v1-0-de259719b6f2@collabora.com/
>    * Only introduce labels in mt7981b.dtsi when required
>    * Switch Airoha EN8811H phy irq to level rather then edge triggered
>    * Move uart0 pinctrl from board dts to soc dtsi
>    * Only overwrite constraints with non-default values in MT7981 bindings
>    * Make SPI NOR nvmem cell labels more meaningfull
>    * Seperate fixing and disable-by-default for the mt7981 in seperate
>      patches
> 
> This series add various peripherals to the Openwrt One, to make it
> actually useful an access point:
> 
> * Pcie express (tested with nvme storage)
> * Wired network interfaces
> * Wireless network interfaces (2.4g, 5ghz wifi)
> * Status leds
> * SPI NOR for factory data
> 
> Unsurprisingly the series is a mix of dt binding updates, extensions of
> the mt7981b and the openwrt one dtb. All driver support required is
> already available.
> 
> Sadly during testing i've found various quirks requiring kernel
> arguments. Documenting those here both as note to self and making it
> easier for others to test :)
> 
> * fw_devlink=permissive: the nvmem fixed-layout doesn't create a layout
>    device, so doesn't trigger fw_devlink

This should really be fixed in fw_devlink I believe. It's not the first device
that uses nvmem fixed-layout and will not be the last one.

> * clk_ignore_unused: Needed when building CONFIG_NET_MEDIATEK_SOC as a
>    module. If the ethernet related clocks (gp1/gp2) get disabled the
>    mac ends up in a weird state causing it not to function correctly.

I'm sure that this can be resolved by adding resets.

> * pcie_aspm: ASPM is forced to enabled in 6.18-rc1, unfortunately
>    enabling ASPM L1.1 ends up triggering unrecoverable AERs.

That must be resolved in the PCIe driver - either it must disable L1.1 support
or needs some fixes around.

Still, I think if you add resets to the PCIe node you should at least get the
MAC recovered at PM resume time (but being this a router, I really don't think
that this would matter - still, for the sake of completion...)

Overall, this series is good and I'm fine with picking all of the changes: even
if there are some needed quirks, those aren't freezing the boot process and the
worst thing that could ever happen is that in some conditions some devices will
simply not probe.
I guess that the resets, etc, can be added later as a fix - but at least we can
get those devices at least partially up and running .

Can anyone pick the bindings please, so that I can pick everything else?

Cheers,
Angelo

> 
> Patches are against the mediatek trees for-next branch
> 
> Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
> ---
> Sjoerd Simons (15):
>        arm64: dts: mediatek: mt7981b: Configure UART0 pinmux
>        arm64: dts: mediatek: mt7981b: Add reserved memory for TF-A
>        dt-bindings: mfd: syscon: Add mt7981-topmisc
>        dt-bindings: PCI: mediatek-gen3: Add MT7981 PCIe compatible
>        dt-bindings: phy: mediatek,tphy: Add support for MT7981
>        arm64: dts: mediatek: mt7981b: Add PCIe and USB support
>        arm64: dts: mediatek: mt7981b-openwrt-one: Enable PCIe and USB
>        dt-bindings: net: mediatek,net: Correct bindings for MT7981
>        arm64: dts: mediatek: mt7981b: Add Ethernet and WiFi offload support
>        arm64: dts: mediatek: mt7981b-openwrt-one: Enable SPI NOR
>        arm64: dts: mediatek: mt7981b-openwrt-one: Enable Ethernet
>        arm64: dts: mediatek: mt7981b: Disable wifi by default
>        arm64: dts: mediatek: mt7981b: Add wifi memory region
>        arm64: dts: mediatek: mt7981b-openwrt-one: Enable wifi
>        arm64: dts: mediatek: mt7981b-openwrt-one: Enable software leds
> 
>   Documentation/devicetree/bindings/mfd/syscon.yaml  |   1 +
>   .../devicetree/bindings/net/mediatek,net.yaml      |  13 +-
>   .../bindings/pci/mediatek-pcie-gen3.yaml           |   1 +
>   .../devicetree/bindings/phy/mediatek,tphy.yaml     |   1 +
>   .../boot/dts/mediatek/mt7981b-openwrt-one.dts      | 263 +++++++++++++++++++++
>   arch/arm64/boot/dts/mediatek/mt7981b.dtsi          | 247 ++++++++++++++++++-
>   6 files changed, 519 insertions(+), 7 deletions(-)
> ---
> base-commit: 860a0efbb95de468b17c86ed5cf8d90ee4bc5d7b
> change-id: 20251016-openwrt-one-network-40bc9ac1b25c
> 
> Best regards,