Re: [PATCH] dt-bindings: usb: mtu3: add mediatek,usb3-drd property

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 16/10/24 00:20, Rob Herring ha scritto:
> On Wed, Oct 16, 2024 at 01:21:00AM +0800, Macpaul Lin wrote:
>> Add optional 'mediatek,usb3-drd' property to MediaTek MTU3 DT Schema.
>> This flag specify whether it is a USB3 Dual-role device hardware.
>>
>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
>> ---
>>   Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> index d4e187c78a0b..1e70af0dac82 100644
>> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> @@ -155,6 +155,12 @@ properties:
>>         property is used. See graph.txt
>>       $ref: /schemas/graph.yaml#/properties/port
>>   
>> +  mediatek,usb3-drd:
>> +    $ref: /schemas/types.yaml#/definitions/flag
>> +    description:
>> +      Specify whether it is a USB3 Dual-role device hardware.
>> +    type: boolean
>> +
> 
> Don't the standard properties such as usb-role-switch or dr_mode work
> for you?
> 

They do - and in fact, the upstream MTU3 driver doesn't even support parsing
the proposed property because it does parse the standard usb-role-switch property.

This means that this commit is not needed at all.

Cheers,
Angelo

>>     enable-manual-drd:
>>       $ref: /schemas/types.yaml#/definitions/flag
>>       description:
>> -- 
>> 2.45.2
>>