Re: [PATCH v14 37/56] media: renesas: Stop direct calls to queue num_buffers field

Andrzej Pietrasiewicz
2023-11-09T11:30:21Z

W dniu 31.10.2023 o 17:30, Benjamin Gaignard pisze:
> Use vb2_get_num_buffers() to avoid using queue num_buffers field directly.
> This allows us to change how the number of buffers is computed in the
> future.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>

Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>

> CC: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---
> drivers/media/platform/renesas/rcar_drif.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rcar_drif.c b/drivers/media/platform/renesas/rcar_drif.c
> index 292c5bf9e50c..f21d05054341 100644
> --- a/drivers/media/platform/renesas/rcar_drif.c
> +++ b/drivers/media/platform/renesas/rcar_drif.c
> @@ -424,10 +424,11 @@ static int rcar_drif_queue_setup(struct vb2_queue *vq,
> unsigned int sizes[], struct device *alloc_devs[])
> {
> struct rcar_drif_sdr *sdr = vb2_get_drv_priv(vq);
> + unsigned int q_num_bufs = vb2_get_num_buffers(vq);
>
> /* Need at least 16 buffers */
> - if (vq->num_buffers + *num_buffers < 16)
> - *num_buffers = 16 - vq->num_buffers;
> + if (q_num_bufs + *num_buffers < 16)
> + *num_buffers = 16 - q_num_bufs;
>
> *num_planes = 1;
> sizes[0] = PAGE_ALIGN(sdr->fmt->buffersize);