Re: [PATCH v14 12/56] media: mediatek: vdec: Remove useless loop

Andrzej Pietrasiewicz
2023-11-09T09:15:10Z

W dniu 31.10.2023 o 17:30, Benjamin Gaignard pisze:
> Simplify code by removing useless loop by using video buffer index.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>

Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>

> CC: Bin Liu <bin.liu@mediatek.com>
> CC: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> .../mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
> index e393e3e668f8..69d37b93bd35 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
> @@ -1695,13 +1695,8 @@ static int vdec_vp9_slice_setup_core_buffer(struct vdec_vp9_slice_instance *inst
> return -EINVAL;
>
> /* update internal buffer's width/height */
> - for (i = 0; i < vq->num_buffers; i++) {
> - if (vb == vq->bufs[i]) {
> - instance->dpb[i].width = w;
> - instance->dpb[i].height = h;
> - break;
> - }
> - }
> + instance->dpb[vb->index].width = w;
> + instance->dpb[vb->index].height = h;
>
> /*
> * get buffer's width/height from instance