From: Caleb James DeLisle <cjd@cjdns.fr>
To: Daniel Golle <daniel@makrotopia.org>
Cc: netdev@vger.kernel.org, dqfext@gmail.com,
SkyLake.Huang@mediatek.com, andrew@lunn.ch, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Matheus Sampaio Queiroga <srherobrine20@gmail.com>
Subject: Re: [PATCH net-next] net: phy: mediatek: support MT7530 PHYs on EN71221 MCM
Date: Thu, 10 Sep 2026 01:26:14 +0200 [thread overview]
Message-ID: <7a3479c8-45cc-4b88-b111-c35d59f370e1@cjdns.fr> (raw)
In-Reply-To: <aqHlfmYa249e3HRM@makrotopia.org>
On 10/09/2026 01:02, Daniel Golle wrote:
> On Wed, Sep 09, 2026 at 09:32:50PM +0000, Caleb James DeLisle wrote:
>> The EcoNet EN751221 multi-chip module implementation of the MT7530
>> requires some additional configuration of the PHYs on startup.
>> The reason for this is not known, but it is possible that it has
>> to do with the fact that the EN751221 MCM implementation of the
>> MT7530 runs at an abnormal PLL frequency (362.5Mhz).
>>
>> Detect whether the MT7530 PHY is attached to the MDIO bus of an
>> EcoNet EN751221 switch and if so, apply the necessary register
>> updates.
>>
>> Co-developed-by: Matheus Sampaio Queiroga <srherobrine20@gmail.com>
>> Signed-off-by: Matheus Sampaio Queiroga <srherobrine20@gmail.com>
>> Signed-off-by: Caleb James DeLisle <cjd@cjdns.fr>
>> ---
>> drivers/net/phy/mediatek/mtk-ge.c | 61 +++++++++++++++++++++++++++++++
>> 1 file changed, 61 insertions(+)
>>
>> diff --git a/drivers/net/phy/mediatek/mtk-ge.c b/drivers/net/phy/mediatek/mtk-ge.c
>> index 73d9b72f9d9e..42b06c40d703 100644
>> --- a/drivers/net/phy/mediatek/mtk-ge.c
>> +++ b/drivers/net/phy/mediatek/mtk-ge.c
>> [...]
>> static int mt7530_phy_config_init(struct phy_device *phydev)
>> {
>> + int ret;
>> +
>> + if (mt7530_phy_is_en751221_companion(phydev)) {
> Please introduce a `.match_phy_device` operation for both, actual
> MT7530 and EN751221, similar eg. to `ksz8051_match_phy_device` in
> micrel.c.
Sounds good, since this will certainly collide with
https://lore.kernel.org/netdev/20260827065930.2618729-2-cjd@cjdns.fr/
would you prefer them in the same patch, or as a patch set? If you'd
like I can do this and the FE phy as a common patch set. Let me know
what you prefer.
Thanks,
Caleb
next prev parent reply other threads:[~2026-09-09 23:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 21:32 [PATCH net-next] net: phy: mediatek: support MT7530 PHYs on EN71221 MCM Caleb James DeLisle
2026-09-09 23:02 ` Daniel Golle
2026-09-09 23:26 ` Caleb James DeLisle [this message]
2026-09-10 1:55 ` Daniel Golle
2026-09-10 6:12 ` Caleb James DeLisle
2026-09-11 10:48 ` Caleb James DeLisle
2026-09-10 2:03 ` Andrew Lunn
2026-09-10 7:01 ` Caleb James DeLisle
2026-09-11 10:39 ` [PATCH v2 " Caleb James DeLisle
2026-09-11 11:58 ` Andrew Lunn
2026-09-11 12:03 ` Caleb James DeLisle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a3479c8-45cc-4b88-b111-c35d59f370e1@cjdns.fr \
--to=cjd@cjdns.fr \
--cc=SkyLake.Huang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=srherobrine20@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox