From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8F16C6FA83 for ; Tue, 27 Sep 2022 08:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u11zg4SgE0WvoIefhu8fd/v/vEo+Ixw+LZY8sttKdWQ=; b=U33exAdBO9YWF1DHzGG7PGoNxj W4DgzfFMqNiIfOPzM6XChJ4JPLvwLsFwL9+zPF66FLTvf4OZIOpOvA2a4ovGYqJurCWmXX1SAjmfm xOlNEF0phsuC13FDsghNEAHDWpzJOC7pHEjLPqm6UgyVhbCNLStyTfbyQ4pRb3ziwo3G8AuDIOfBY 3yg3KbF34+6JkYSmJq7M8vwKCDF5YLBHzfhthz0IWIcP6oGbLGKdL6/aExjMczrUSyMZtQ4TkkKC6 tylxo4a+IiRGILi+q88z4G8jhClEC304mW601eUeTiCvkXyQOCUB/sMGklZurypiovAeqYPvss4Vs bC6iFtHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1od64f-009Cis-5X; Tue, 27 Sep 2022 08:36:17 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1od61s-009BTK-Dh; Tue, 27 Sep 2022 08:33:26 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id ED7CD1884A23; Tue, 27 Sep 2022 08:33:10 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id CE0B82500015; Tue, 27 Sep 2022 08:33:10 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id B2A64A0A1E66; Tue, 27 Sep 2022 08:33:10 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Tue, 27 Sep 2022 10:33:10 +0200 From: netdev@kapio-technology.com To: Ido Schimmel Cc: Vladimir Oltean , davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Christian Marangi , Daniel Borkmann , Yuwei Wang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 net-next 6/6] selftests: forwarding: add test of MAC-Auth Bypass to locked port tests In-Reply-To: References: <5cee059b65f6f7671e099150f9da79c1@kapio-technology.com> <8dfc9b525f084fa5ad55019f4418a35e@kapio-technology.com> <20220908112044.czjh3xkzb4r27ohq@skbuf> <152c0ceadefbd742331c340bec2f50c0@kapio-technology.com> <20220911001346.qno33l47i6nvgiwy@skbuf> <15ee472a68beca4a151118179da5e663@kapio-technology.com> <086704ce7f323cc1b3cca78670b42095@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: <7a4549d645f9bbbf41e814f087eb07d1@kapio-technology.com> X-Sender: netdev@kapio-technology.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_013324_685264_28FB8B91 X-CRM114-Status: UNSURE ( 9.33 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 2022-09-21 09:15, Ido Schimmel wrote: > bridge fdb add `mac_get $h2` dev br0 blackhole To make this work, I think we need to change the concept, so that blackhole FDB entries are added to ports connected to the bridge, thus bridge fdb add MAC dev $swpX master blackhole This makes sense as the driver adds them based on the port where the SMAC is seen, even though the effect of the blackhole FDB entry is switch wide. Adding them to the bridge (e.g. f.ex. br0) will not work in the SW bridge as the entries then are not found. We could deny this possibility or just document the use? For offloaded I can change the add, so that it does a delete (even if none are present) and a add, thus facilitating the replace. How does this sound?