From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9957C35FFC for ; Wed, 19 Mar 2025 14:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=p8RxMnWWsFYazqDi5ausaz27iCUKurnoSgUaIXr1DG4=; b=mwT8os0LbHEghxXckRRccsJlnh rUJ3gQ1fEL3g7g62IhAG43CjZBZILJC00NHUCg8q6QHJfoZ+lJuSak5cAdPWTDz+mgkF1/T2h3yzF Bha9Ahsoa2scCNhC4N3RIwu1+9/dw/j7NpjbzVNRfizJ4Mi9iWKItUdHQ9djVLqEa5yMZ1TF2cKgS 1hmYjnWj4GMrJn40wwyWxptF7NapGgHxLe/Sr5a13fQbsg0gJY6/2k2xn1Ca6grBbbIBkJjotLL+Z P2dU89tyKhHedCVdzjmTOve0bFqDmp4znRuBnczCuVnyv0KaUK7TJFVj9+6/oBHJFR90rjJaI9bk8 KW0thObQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tuuP5-00000009Cw1-3VgR; Wed, 19 Mar 2025 14:28:19 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tuuMG-00000009CTG-2B7u; Wed, 19 Mar 2025 14:25:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1742394322; bh=dFq9WrBtYmONyZNM0GrXKYpn3Y8FJf3WJUh0aWFuRDI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XEaBF0Zw5wjvy+eBCil3EcYkJF2wSPeFtX1kPSWyGjhnxBDElCHihextQz/qmFjc8 /wrYmrpDXW58niMFnfxdg7iyC0fd7TagGcq2Phgp3JcGgh3wamxXZ+hMxCxYpiI3ys /j4rEt17Bsf4qH5OHPs2xpAZKlkZgeed5yib6nF/Mb77Y8FT4XS83pgviijv+i2MId TGT7GNwykxbXkQUDzRk6yfu9PB+7+DYlBuX5EJIEMhApA0zQin2wtfDnE/jS40scjd 03WgDdnp1pqnqi/QMUGcMRm6BEYDQsi5r3TJCYp5u0ve8/Hl08Ja8ULWMPavOR3kvI GQy1jOiW5CnmQ== Received: from notapiano (unknown [70.107.117.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by bali.collaboradmins.com (Postfix) with ESMTPSA id 4313B17E0599; Wed, 19 Mar 2025 15:25:20 +0100 (CET) Date: Wed, 19 Mar 2025 11:25:18 -0300 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Krzysztof Kozlowski Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Tinghan Shen , Olivia Wen , kernel@collabora.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 1/4] dt-bindings: remoteproc: mediatek: Add missing minItems for 8192/8195 Message-ID: <7ab084b8-e77a-4881-a6a6-057b89613fb4@notapiano> References: <20250318-scp-dual-core-mt8390-v1-0-8733e192cc73@collabora.com> <20250318-scp-dual-core-mt8390-v1-1-8733e192cc73@collabora.com> <3fa1573d-e3b4-434c-867d-38fa69ad3a8e@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3fa1573d-e3b4-434c-867d-38fa69ad3a8e@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250319_072524_706403_DADFDD9C X-CRM114-Status: GOOD ( 18.49 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Mar 19, 2025 at 08:16:37AM +0100, Krzysztof Kozlowski wrote: > On 18/03/2025 23:22, Nícolas F. R. A. Prado wrote: > > Both MT8192 and MT8195 have an L1TCM memory, so it should be described > > in reg, and therefore reg's minItems should be 3, as is already implicit > > by reg-names. Override minItems to 3 for MT8192 and MT8195. > > I think that was the original intention already, because reg-names are > expecting min 3 items. Basically you just correct the missing lower > constraint. Yes, exactly, that's what I meant by "is already implicit by reg-names". > > > > > Fixes: 6b55b1e2fd7f ("dt-bindings: remoteproc: mediatek: Support MT8195 dual-core SCP") > > Signed-off-by: Nícolas F. R. A. Prado > > --- > > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > index adc6b3f36fde49eb3fa7ed3f08b0fa9e7f331162..ee33c233e44f3d51f0851b35697a24208c87f68a 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > > @@ -185,6 +185,7 @@ allOf: > > then: > > properties: > > reg: > > + minItems: 3 > > maxItems: 3 > > maxItems can be dropped. Sure, I can send a patch for that in the next version. Thanks, Nícolas