From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AD78C3ABC9 for ; Tue, 13 May 2025 19:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oORfCjjMp0fnf0bcbRrrnwFPePQZmNvhaaRtgbRBFe0=; b=cz2Iod4lE1U9OiJm5rRilCzKRm dM1GZ8GHdOnv0hq62GaoNehoYhWP1fA1Bo9C/irPAJ3TVCe0VxLpHw5f1z3Bu94Azj5jyHg1DQUMk XU1PUt3gFWCThSQ+UlF5U7zUyNWLT15NZDnu3kcgzMVxiNo+wu5cyufu0fjJKG3z0/eMnfWkc2m6e mspX39l6HA0MhaIJw2JaHnCYFcuQbYD34PWFmDv4ag/as5cEdrkBq4j/KJ6ypSJlRboTlqel6b4Xm j/Xw3PRqqhEXybCU0oAucrWTczUC2MyFoGnfZp+EueY0cmGMxOux0GS9qSztaBAsR8JgCg+tMZB7m EV1qrGgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uEvY6-0000000DPCu-21EM; Tue, 13 May 2025 19:44:22 +0000 Received: from out-178.mta0.migadu.com ([91.218.175.178]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uEvWA-0000000DOzL-1TWf for linux-mediatek@lists.infradead.org; Tue, 13 May 2025 19:42:23 +0000 Message-ID: <7ac6c796-cf4e-47ba-bde3-0f8c6203fea0@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1747165329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oORfCjjMp0fnf0bcbRrrnwFPePQZmNvhaaRtgbRBFe0=; b=cxLMPGYWVPzTxFMRw78DNhHqfwOH3hxsXpMukZ4w8AqwLDGm3QNvqpFXuCYpUPl8Ye4YHw D9q800LclkE2zLFSqN1vKgNYLywjbcPtFStoJFUWpGqZlOsWDzKC4Eky3H/KZLoExeAsBE t6rTt50Rl0eNCU1ijMLdKJnfD61xUMk= Date: Tue, 13 May 2025 15:42:04 -0400 MIME-Version: 1.0 Subject: Re: [net-next PATCH v4 03/11] net: phylink: introduce internal phylink PCS handling X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson To: Daniel Golle Cc: Christian Marangi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lorenzo Bianconi , Heiner Kallweit , Russell King , Philipp Zabel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, llvm@lists.linux.dev References: <20250511201250.3789083-1-ansuelsmth@gmail.com> <20250511201250.3789083-4-ansuelsmth@gmail.com> <5d004048-ef8f-42ad-8f17-d1e4d495f57f@linux.dev> <7b50d202-e7f6-41cb-b868-6e6b33d4a2b9@linux.dev> Content-Language: en-US In-Reply-To: <7b50d202-e7f6-41cb-b868-6e6b33d4a2b9@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250513_124222_532655_856C4ECF X-CRM114-Status: GOOD ( 11.14 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 5/13/25 15:23, Sean Anderson wrote: > On 5/13/25 15:03, Daniel Golle wrote: >> On Tue, May 13, 2025 at 02:18:02PM -0400, Sean Anderson wrote: >>> DSA drivers typically have different PCSs for each port. At the moment >>> these are selected with mac_select_pcs, allowing the use of a single >>> phylink_config for each port. If you need to pass PCSs through >>> phylink_config then each port will needs its own config. This may prove >>> difficult to integrate with the existing API. >> >> This might be a misunderstanding. Also here there is only a single >> phylink_config for each MAC or DSA port, > > My point is that while this is the case at the moment, it would not be > the case with a "generic" select pcs. You would need to modify the > config for each port to ensure the right PCSs are passed in. I reread dsa_port_phylink_create and I think I missed the ds/dp distinction the first time around. --Sean