From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1464BC04A95 for ; Thu, 29 Sep 2022 01:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KLeXZkzgR5Ay7eOUvGeW+A2UOiV7iAhJfQA6fiC/fas=; b=AUiyH2seJSOQk9ZFfr8NstdZrv 2TRbz09pl3f2mjIB4+c2fPRNZRjOX7zie/P3GHxIVGF/6IEO8Uowb+LssDEvxrb8iO4htD5FF4sQb M0Q0KabVDiqAjl+vqRd4oU2JhaC9n+leJVObK5MD35oLlW/hO3hEwFdEiHVUm+B5pUTC2UC1mjRQ0 /uHvGKIXoLADHli89dqFgSHKPMHdd2njeAtTuFIbaT5TsoTuVt+m/sA/P/MkNYko1zQy7QkJRw0cC oXSEpVT24r5K10yf/9fhk3Ou9A2uAt6rju4Ai2TZlD5YPxmXX9iuDR4OY22pDcmLEoK/743s2HmOz 1oAVyf7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odimJ-000uit-OR; Thu, 29 Sep 2022 01:55:55 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odim8-000ugy-Ud; Thu, 29 Sep 2022 01:55:46 +0000 X-UUID: de4fdf0f4cc4485e877d133ebf335407-20220928 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=KLeXZkzgR5Ay7eOUvGeW+A2UOiV7iAhJfQA6fiC/fas=; b=SHqr0Cunqo5xnMTy2hauXSokoFUcURgPaoM913LTUazCm4o97CKrIJLs3234Cul2LSmmJ/gEA5I7WKKbQA3LlwcufLD31RAv+LAo/QcNTGsHUzbkbAMkwYs59K8SdTIn5BqKcgITpoD3m7TfNWuo3nXw/spYZdWgqpqebgLVVvE=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.11,REQID:c9036338-191e-43d9-8734-e13f86bf0fa2,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:39a5ff1,CLOUDID:44df5e07-1cee-4c38-b21b-a45f9682fdc0,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: de4fdf0f4cc4485e877d133ebf335407-20220928 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 153283290; Wed, 28 Sep 2022 18:55:37 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Thu, 29 Sep 2022 09:54:58 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Thu, 29 Sep 2022 09:54:57 +0800 Message-ID: <7d8fb7ea78ae2a850d26bba7b08f621b8494df5e.camel@mediatek.com> Subject: Re: [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile From: "yunfei.dong@mediatek.com" To: Allen-KH Cheng =?UTF-8?Q?=28=E7=A8=8B=E5=86=A0=E5=8B=B3=29?= , "robh+dt@kernel.org" , Tiffany Lin =?UTF-8?Q?=28=E6=9E=97=E6=85=A7=E7=8F=8A=29?= , "mchehab@kernel.org" , "nicolas.dufresne@collabora.com" , Irui Wang =?UTF-8?Q?=28=E7=8E=8B=E7=91=9E=29?= , "hsinyi@chromium.org" , "hverkuil-cisco@xs4all.nl" , "matthias.bgg@gmail.com" , "angelogioacchino.delregno@collabora.com" , "acourbot@chromium.org" CC: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , Longfei Wang =?UTF-8?Q?=28=E7=8E=8B=E9=BE=99=E9=A3=9E=29?= , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , Maoguang Meng =?UTF-8?Q?=28=E5=AD=9F=E6=AF=9B=E5=B9=BF=29?= , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" Date: Thu, 29 Sep 2022 09:54:56 +0800 In-Reply-To: References: <20220926093501.26466-1-irui.wang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220928_185545_001507_E3728912 X-CRM114-Status: GOOD ( 16.79 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Irui, Reviewed-by: Yunfei Dong Thanks Yunfei Dong On Wed, 2022-09-28 at 21:38 +0800, Allen-KH Cheng (程冠勳) wrote: > Hi Irui, > > Tested-by: Allen-KH Cheng > > Tested for CTS cases on the mt8186 corsola board. > > Thanks, > Allen > > On Mon, 2022-09-26 at 17:35 +0800, Irui Wang wrote: > > The encoder driver support h264 baseline, main, high encoder > > profile, set mask for V4L2_CID_MPEG_VIDEO_H264_PROFILE to skip > > the unsupported profile. > > > > get supported h264_profile by command: v4l2-ctl -d /dev/videoX -L > > h264_profile 0x00990a6b (menu) : min=0 max=4 default=4 value=4 > > 0: Baseline > > 2: Main > > 4: High > > > > Signed-off-by: Irui Wang > > --- > > drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git > > a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c > > b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c > > index d810a78dde51..d65800a3b89d 100644 > > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c > > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c > > @@ -1397,7 +1397,10 @@ int mtk_vcodec_enc_ctrls_setup(struct > > mtk_vcodec_ctx *ctx) > > 0, V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE); > > v4l2_ctrl_new_std_menu(handler, ops, > > V4L2_CID_MPEG_VIDEO_H264_PROFILE, > > V4L2_MPEG_VIDEO_H264_PROFILE_HIGH, > > - 0, V4L2_MPEG_VIDEO_H264_PROFILE_HIGH); > > + ~((1 << V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE) > > > > > > > + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_MAIN) | > > + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_HIGH)), > > + V4L2_MPEG_VIDEO_H264_PROFILE_HIGH); > > v4l2_ctrl_new_std_menu(handler, ops, > > V4L2_CID_MPEG_VIDEO_H264_LEVEL, > > h264_max_level, > > 0, V4L2_MPEG_VIDEO_H264_LEVEL_4_0);