From: "Arnd Bergmann" <arnd@arndb.de>
To: "Kees Cook" <keescook@chromium.org>,
"Russell King" <linux@armlinux.org.uk>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Lecopzer Chen" <lecopzer.chen@mediatek.com>,
"Oleg Nesterov" <oleg@redhat.com>,
linux-arm-kernel@lists.infradead.org,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Wolfram Sang" <wsa@kernel.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Russell King" <rmk+kernel@armlinux.org.uk>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ARM: ptrace: Restore syscall skipping for tracers
Date: Thu, 10 Aug 2023 22:11:08 +0200 [thread overview]
Message-ID: <7e137ddd-a954-4a2e-89ac-5d2cb59775de@app.fastmail.com> (raw)
In-Reply-To: <20230810195422.2304827-2-keescook@chromium.org>
On Thu, Aug 10, 2023, at 21:54, Kees Cook wrote:
> Since commit 4e57a4ddf6b0 ("ARM: 9107/1: syscall: always store
> thread_info->abi_syscall"), the seccomp selftests "syscall_errno"
> and "syscall_faked" have been broken. Both seccomp and PTRACE depend
> on using the special value of "-1" for skipping syscalls. This value
> wasn't working because it was getting masked by __NR_SYSCALL_MASK in
> both PTRACE_SET_SYSCALL and get_syscall_nr().
>
> Explicitly test for -1 in PTRACE_SET_SYSCALL and get_syscall_nr(),
> leaving it exposed when present, allowing tracers to skip syscalls
> again.
>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Arnd Bergmann <arnd@kernel.org>
> Cc: Lecopzer Chen <lecopzer.chen@mediatek.com>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Fixes: 4e57a4ddf6b0 ("ARM: 9107/1: syscall: always store
> thread_info->abi_syscall")
> Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2023-08-10 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 19:54 [PATCH v2 0/2] ARM: ptrace: Restore syscall skipping and restart while tracing Kees Cook
2023-08-10 19:54 ` [PATCH v2 1/2] ARM: ptrace: Restore syscall restart tracing Kees Cook
2023-08-10 20:17 ` Arnd Bergmann
2023-08-10 19:54 ` [PATCH v2 2/2] ARM: ptrace: Restore syscall skipping for tracers Kees Cook
2023-08-10 20:11 ` Arnd Bergmann [this message]
2023-08-11 5:55 ` [PATCH v2 0/2] ARM: ptrace: Restore syscall skipping and restart while tracing Kees Cook
2023-08-16 20:59 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e137ddd-a954-4a2e-89ac-5d2cb59775de@app.fastmail.com \
--to=arnd@arndb.de \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=keescook@chromium.org \
--cc=lecopzer.chen@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=oleg@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox