From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Fei Shao <fshao@chromium.org>, Chen-Yu Tsai <wenst@chromium.org>
Cc: Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: mediatek: mt8186-corsola: Update ADSP reserved memory region
Date: Fri, 19 Jul 2024 11:21:58 +0200 [thread overview]
Message-ID: <7edb3361-9e53-44ad-82ec-b2c81834b2ea@collabora.com> (raw)
In-Reply-To: <20240719045823.3264974-1-fshao@chromium.org>
Il 19/07/24 06:58, Fei Shao ha scritto:
> Corsola firmware reserves the memory region of [0x60000000, 0x61100000)
Sorry but if the region is supposed to be 0x1100000 long....
> exclusively for ADSP usage.
> But in fact, a 6 MB "hole" of [0x60A00000, 0x61000000) didn't get
> assigned to the ADSP node in the Corsola device tree, meaning no audio
> tasks can access and utilize that memory section.
>
> Update the reserved ADSP memory region to fill the gap.
>
> Fixes: 8855d01fb81f ("arm64: dts: mediatek: Add MT8186 Krabby platform based Tentacruel / Tentacool")
> Signed-off-by: Fei Shao <fshao@chromium.org>
> ---
>
> arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> index afdab5724eaa..0c4a26117428 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> @@ -169,7 +169,7 @@ adsp_dma_mem: memory@61000000 {
>
> adsp_mem: memory@60000000 {
> compatible = "shared-dma-pool";
> - reg = <0 0x60000000 0 0xA00000>;
> + reg = <0 0x60000000 0 0x1000000>;
...why are you making it 0x1000000 long?
Cheers,
Angelo
> no-map;
> };
>
next prev parent reply other threads:[~2024-07-19 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 4:58 [PATCH] arm64: dts: mediatek: mt8186-corsola: Update ADSP reserved memory region Fei Shao
2024-07-19 9:21 ` AngeloGioacchino Del Regno [this message]
2024-07-22 3:37 ` Fei Shao
2024-07-22 9:10 ` AngeloGioacchino Del Regno
2024-08-06 11:10 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7edb3361-9e53-44ad-82ec-b2c81834b2ea@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fshao@chromium.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox